You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/02/01 13:52:34 UTC

[GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...

Github user ramkrish86 commented on the pull request:

    https://github.com/apache/flink/pull/1553#issuecomment-177957906
  
    I went through the code. In both cases of WordCount program with and without explicit partition
    `[Map] --hash-partition--> [Reduce]`
    `[Map] --partition--> [Partition] --local-fwd--> [Reduce]`
    I see that it goes to the 'else' part of the GroupReduceWithCombineProperties#instantiate() method. I debugged once again for both cases. 
    
    > hence, the code enters the if case, because the input shipping strategy is FORWARD.
    So with an explicit partitioner I don't see that happening. The input shipping strategy of the PARTITION node seems to have PARTITION_HASH as the strategy. 
    So what am I missing here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---