You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/08 02:16:07 UTC

Review Request 33962: Remove often-redundant "Error executing command" prefix from client output.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33962/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1310
    https://issues.apache.org/jira/browse/AURORA-1310


Repository: aurora


Description
-------

See summary.


Diffs
-----

  src/main/python/apache/aurora/client/cli/__init__.py 1208846b9202b600ada63c1cebfa95bf3e30b824 
  src/main/python/apache/aurora/client/cli/update.py 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
  src/test/python/apache/aurora/client/cli/test_create.py 4de0ecba763af03a0b96900567a7c53853e548db 
  src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853 
  src/test/python/apache/aurora/client/cli/test_supdate.py 6fb1f71b7dc787c090fce7b8e7c51baee862f336 

Diff: https://reviews.apache.org/r/33962/diff/


Testing
-------

Unit tests.


Thanks,

Bill Farner


Re: Review Request 33962: Remove often-redundant "Error executing command" prefix from client output.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33962/#review82947
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On May 8, 2015, 12:16 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33962/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 12:16 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1310
>     https://issues.apache.org/jira/browse/AURORA-1310
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 1208846b9202b600ada63c1cebfa95bf3e30b824 
>   src/main/python/apache/aurora/client/cli/update.py 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_create.py 4de0ecba763af03a0b96900567a7c53853e548db 
>   src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
> 
> Diff: https://reviews.apache.org/r/33962/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33962: Remove often-redundant "Error executing command" prefix from client output.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33962/#review82948
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On May 8, 2015, 12:16 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33962/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 12:16 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1310
>     https://issues.apache.org/jira/browse/AURORA-1310
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 1208846b9202b600ada63c1cebfa95bf3e30b824 
>   src/main/python/apache/aurora/client/cli/update.py 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_create.py 4de0ecba763af03a0b96900567a7c53853e548db 
>   src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
> 
> Diff: https://reviews.apache.org/r/33962/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 33962: Remove often-redundant "Error executing command" prefix from client output.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33962/#review82955
-----------------------------------------------------------

Ship it!


Master (27b5e25) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On May 8, 2015, 12:16 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33962/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 12:16 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1310
>     https://issues.apache.org/jira/browse/AURORA-1310
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 1208846b9202b600ada63c1cebfa95bf3e30b824 
>   src/main/python/apache/aurora/client/cli/update.py 8296db5434276910fc4f8470c7a962a8e8e0a9c2 
>   src/test/python/apache/aurora/client/cli/test_create.py 4de0ecba763af03a0b96900567a7c53853e548db 
>   src/test/python/apache/aurora/client/cli/test_kill.py 09734a7981b0f41abd0c8667caf2b121a3205853 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 6fb1f71b7dc787c090fce7b8e7c51baee862f336 
> 
> Diff: https://reviews.apache.org/r/33962/diff/
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>