You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2009/12/06 23:17:18 UTC
[jira] Created: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
---------------------------------------------------------------------------------------------------
Key: LUCENE-2122
URL: https://issues.apache.org/jira/browse/LUCENE-2122
Project: Lucene - Java
Issue Type: Improvement
Components: Other
Affects Versions: 3.1
Reporter: Erick Erickson
Assignee: Erick Erickson
Priority: Minor
Fix For: 3.1
Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Well, under any circumstances, the line
Locale.setDefault(Locale.getDefault());
was just plain silly. At the cost of setting the
default locale exactly once per test *class*
(I used @BeforeClass/@AfterClass), I'd
far rather err on the side of paranoia than
cause someone to spend *hours* figuring
it out...
On Sun, Dec 6, 2009 at 8:41 PM, Robert Muir <rc...@gmail.com> wrote:
> Erick, btw I may not be right about this... certainly if you are invoking
> each test in its own JVM it should be no problem... its just some paranoia.
>
> also this same "changing of JRE-system wide variable" would prevent these
> tests from being parallelized in the same jvm, in case that matters... (they
> should run in their own jvm sequentially)
>
> LocalizedTestCase is nasty, I admit, but it works and prevents hours of
> changing variables and running ant test under different locales... just one
> of those things
>
> thanks for tackling this one
>
>
> On Sun, Dec 6, 2009 at 8:30 PM, Erick Erickson <er...@gmail.com>wrote:
>
>> I just made a comment on how many times
>> I've made the "that looks unnecessary, I'll
>> take it out" mistake. Now I get to add one to
>> that total.
>>
>> I'll attach a revised patch momentarily with this
>> change.
>>
>> Thanks for pointing this out!
>>
>> Erick
>>
>>
>> On Sun, Dec 6, 2009 at 8:00 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786749#action_12786749]
>>>
>>> Robert Muir commented on LUCENE-2122:
>>> -------------------------------------
>>>
>>> Hi Erick, I am a little nervous about the change to
>>> LocalizedTestCase.tearDown() here.
>>>
>>> I think we must restore the users default Locale, since its a JRE-system
>>> wide global thing and we are changing it on the fly here.
>>>
>>> this was stashed away here before:
>>> {code}
>>> /**
>>> * Before changing the default Locale, save the default Locale here so
>>> that it
>>> * can be restored.
>>> */
>>> private final Locale defaultLocale = Locale.getDefault();
>>> {code}
>>>
>>> and restored in tearDown()... otherwise strange things could happen, such
>>> as your IDE could go bonkers after running the tests! (but maybe I am
>>> missing something)
>>>
>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>> deriving from LocalizedTestCase
>>> >
>>> ---------------------------------------------------------------------------------------------------
>>> >
>>> > Key: LUCENE-2122
>>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>>> > Project: Lucene - Java
>>> > Issue Type: Improvement
>>> > Components: Other
>>> > Affects Versions: 3.1
>>> > Reporter: Erick Erickson
>>> > Assignee: Erick Erickson
>>> > Priority: Minor
>>> > Fix For: 3.1
>>> >
>>> > Attachments: LUCENE-2122.patch
>>> >
>>> >
>>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>>> testing of Locales.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Robert Muir <rc...@gmail.com>.
Erick, btw I may not be right about this... certainly if you are invoking
each test in its own JVM it should be no problem... its just some paranoia.
also this same "changing of JRE-system wide variable" would prevent these
tests from being parallelized in the same jvm, in case that matters... (they
should run in their own jvm sequentially)
LocalizedTestCase is nasty, I admit, but it works and prevents hours of
changing variables and running ant test under different locales... just one
of those things
thanks for tackling this one
On Sun, Dec 6, 2009 at 8:30 PM, Erick Erickson <er...@gmail.com>wrote:
> I just made a comment on how many times
> I've made the "that looks unnecessary, I'll
> take it out" mistake. Now I get to add one to
> that total.
>
> I'll attach a revised patch momentarily with this
> change.
>
> Thanks for pointing this out!
>
> Erick
>
>
> On Sun, Dec 6, 2009 at 8:00 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786749#action_12786749]
>>
>> Robert Muir commented on LUCENE-2122:
>> -------------------------------------
>>
>> Hi Erick, I am a little nervous about the change to
>> LocalizedTestCase.tearDown() here.
>>
>> I think we must restore the users default Locale, since its a JRE-system
>> wide global thing and we are changing it on the fly here.
>>
>> this was stashed away here before:
>> {code}
>> /**
>> * Before changing the default Locale, save the default Locale here so
>> that it
>> * can be restored.
>> */
>> private final Locale defaultLocale = Locale.getDefault();
>> {code}
>>
>> and restored in tearDown()... otherwise strange things could happen, such
>> as your IDE could go bonkers after running the tests! (but maybe I am
>> missing something)
>>
>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>> deriving from LocalizedTestCase
>> >
>> ---------------------------------------------------------------------------------------------------
>> >
>> > Key: LUCENE-2122
>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>> > Project: Lucene - Java
>> > Issue Type: Improvement
>> > Components: Other
>> > Affects Versions: 3.1
>> > Reporter: Erick Erickson
>> > Assignee: Erick Erickson
>> > Priority: Minor
>> > Fix For: 3.1
>> >
>> > Attachments: LUCENE-2122.patch
>> >
>> >
>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>> testing of Locales.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
--
Robert Muir
rcmuir@gmail.com
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
I just made a comment on how many times
I've made the "that looks unnecessary, I'll
take it out" mistake. Now I get to add one to
that total.
I'll attach a revised patch momentarily with this
change.
Thanks for pointing this out!
Erick
On Sun, Dec 6, 2009 at 8:00 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786749#action_12786749]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> Hi Erick, I am a little nervous about the change to
> LocalizedTestCase.tearDown() here.
>
> I think we must restore the users default Locale, since its a JRE-system
> wide global thing and we are changing it on the fly here.
>
> this was stashed away here before:
> {code}
> /**
> * Before changing the default Locale, save the default Locale here so
> that it
> * can be restored.
> */
> private final Locale defaultLocale = Locale.getDefault();
> {code}
>
> and restored in tearDown()... otherwise strange things could happen, such
> as your IDE could go bonkers after running the tests! (but maybe I am
> missing something)
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Assignee: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Hmmmmm, I agree there shouldn't be any *good* reason for a race condition
to exist, it should all be single-threaded anyway. That said, one difference
is certainly that the original Locale is stored in a *static* var rather
than
a class var. I have no objection to moving the save/restore to
@Before and @After rather than @BeforeClass and @AfterClass and
making the original Locale not be static.
I'd be interested if that makes your problem go away, and if it does why.
And whether you'd get the same results if we synchronized get/set of
the original Locale..... And if this made a difference, it would worry me...
Erick
On Fri, Dec 11, 2009 at 9:26 AM, Robert Muir <rc...@gmail.com> wrote:
> Erick I will play with it some more and see if i can recreate this behavior
> somehow.
> I do not see a problem with the code, and think that if there is a race,
> there should have been one before with the old LocalizedTestCase (as the
> behavior is the same, we are changing a system-wide static)
>
> The only small difference is that this happens @BeforeClass with the new
> one, versus @Before with the old one?
>
>
> On Fri, Dec 11, 2009 at 9:05 AM, Erick Erickson <er...@gmail.com>wrote:
>
>> So I ran this test suite from Idea a dozen times or so and no problem.
>>
>> Then I ran it a couple of thousand times through Ant via a shell
>> script. No problem.
>>
>> So I'm tending toward thinking it's an Eclipse issue, what do
>> you think?
>>
>> Erick
>>
>>
>> On Thu, Dec 10, 2009 at 4:23 PM, Erick Erickson <er...@gmail.com>wrote:
>>
>>> I'll give this a whirl tonight. The reason I was wondering what language
>>> is to insure that my machine *also* tests the offending locale.....
>>>
>>> A bit of a nit, the flaw in the approach with LocalizedTestCase is
>>> that *every* test in the class is run against *all* locales......
>>> To change this, as I understand it, we'd need to break the tests
>>> out into a separate class.......
>>>
>>> Intermittent errors often smell like a race condition, so I'll be
>>> on the lookout for one.
>>>
>>> But I also wonder if you'd ever get this error running outside
>>> of Eclipse.
>>>
>>> I really, really, really hate ones like this. Let's say you have a script
>>> that runs 1,000 times flawlessly from the shell. What does that prove?
>>> <nasty grin>.
>>>
>>> But maybe if I relentlessly press the test button on that class it'll
>>> happen
>>> to me too....
>>>
>>> FWIW
>>> Erick
>>>
>>> On Thu, Dec 10, 2009 at 3:30 PM, Robert Muir <rc...@gmail.com> wrote:
>>>
>>>> i just right clicked TestQueryParser and said 'run as junit test'
>>>>
>>>> i could not tell which locales failed, (just testing your original
>>>> patch, no modifications)
>>>> the way they are shown instead is like an array of 135 elements...
>>>> [0]: testCJK[0] (0.000s)
>>>> testSimple[0] (0.001s)
>>>> ...
>>>> [1]: testCJK[1] (0.000s)
>>>> ...
>>>> [135] testCJK[135]
>>>>
>>>> the only tests that failed were the localized methods like the date
>>>> stuff, where its going to create an 'expected' localized string and then
>>>> compare against that.
>>>> it makes me suspect that somehow there is some race, and the default
>>>> locale is actually changing as the test is running, or something crazy like
>>>> this?!
>>>>
>>>>
>>>>
>>>> On Thu, Dec 10, 2009 at 3:23 PM, Erick Erickson <
>>>> erickerickson@gmail.com> wrote:
>>>>
>>>>> Yep, that sure makes me nervous too. I've never seen a failure in
>>>>> IntelliJ or from a
>>>>> shell window.
>>>>>
>>>>> How often do you need to run it to see an error? And what language is
>>>>> it using?
>>>>> And what test?
>>>>>
>>>>> I can try this in my IntelliJ setup and see if I can reproduce it. Note
>>>>> I'm running
>>>>> on a Macbook Pro...
>>>>>
>>>>> I wonder if a repeating script would show an intermittent error........
>>>>>
>>>>> Erick
>>>>>
>>>>>
>>>>> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>>>>
>>>>>>
>>>>>> [
>>>>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>>>>>>
>>>>>> Robert Muir commented on LUCENE-2122:
>>>>>> -------------------------------------
>>>>>>
>>>>>> Hi Erick, I played with this patch some and (not intentionally trying)
>>>>>> I would get random test failures for TestQueryParser under eclipse... its
>>>>>> not really something I am able to repeat though.
>>>>>>
>>>>>> maybe some race condition (I do not know how eclipse executes
>>>>>> parameterized tests).... ?
>>>>>>
>>>>>> if it is a problem with my IDE that is one thing, just makes me a
>>>>>> little nervous right now. trying to think what could cause this....
>>>>>>
>>>>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>>>>> deriving from LocalizedTestCase
>>>>>> >
>>>>>> ---------------------------------------------------------------------------------------------------
>>>>>> >
>>>>>> > Key: LUCENE-2122
>>>>>> > URL:
>>>>>> https://issues.apache.org/jira/browse/LUCENE-2122
>>>>>> > Project: Lucene - Java
>>>>>> > Issue Type: Improvement
>>>>>> > Components: Other
>>>>>> > Affects Versions: 3.1
>>>>>> > Reporter: Erick Erickson
>>>>>> > Assignee: Robert Muir
>>>>>> > Priority: Minor
>>>>>> > Fix For: 3.1
>>>>>> >
>>>>>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>>>>>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>>>>>> >
>>>>>> >
>>>>>> > Use the @Parameterized capabilities of Junit4 to allow more
>>>>>> extensive testing of Locales.
>>>>>>
>>>>>> --
>>>>>> This message is automatically generated by JIRA.
>>>>>> -
>>>>>> You can reply to this email to add a comment to the issue online.
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Robert Muir
>>>> rcmuir@gmail.com
>>>>
>>>
>>>
>>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Robert Muir <rc...@gmail.com>.
Erick I will play with it some more and see if i can recreate this behavior
somehow.
I do not see a problem with the code, and think that if there is a race,
there should have been one before with the old LocalizedTestCase (as the
behavior is the same, we are changing a system-wide static)
The only small difference is that this happens @BeforeClass with the new
one, versus @Before with the old one?
On Fri, Dec 11, 2009 at 9:05 AM, Erick Erickson <er...@gmail.com>wrote:
> So I ran this test suite from Idea a dozen times or so and no problem.
>
> Then I ran it a couple of thousand times through Ant via a shell
> script. No problem.
>
> So I'm tending toward thinking it's an Eclipse issue, what do
> you think?
>
> Erick
>
>
> On Thu, Dec 10, 2009 at 4:23 PM, Erick Erickson <er...@gmail.com>wrote:
>
>> I'll give this a whirl tonight. The reason I was wondering what language
>> is to insure that my machine *also* tests the offending locale.....
>>
>> A bit of a nit, the flaw in the approach with LocalizedTestCase is
>> that *every* test in the class is run against *all* locales......
>> To change this, as I understand it, we'd need to break the tests
>> out into a separate class.......
>>
>> Intermittent errors often smell like a race condition, so I'll be
>> on the lookout for one.
>>
>> But I also wonder if you'd ever get this error running outside
>> of Eclipse.
>>
>> I really, really, really hate ones like this. Let's say you have a script
>> that runs 1,000 times flawlessly from the shell. What does that prove?
>> <nasty grin>.
>>
>> But maybe if I relentlessly press the test button on that class it'll
>> happen
>> to me too....
>>
>> FWIW
>> Erick
>>
>> On Thu, Dec 10, 2009 at 3:30 PM, Robert Muir <rc...@gmail.com> wrote:
>>
>>> i just right clicked TestQueryParser and said 'run as junit test'
>>>
>>> i could not tell which locales failed, (just testing your original patch,
>>> no modifications)
>>> the way they are shown instead is like an array of 135 elements...
>>> [0]: testCJK[0] (0.000s)
>>> testSimple[0] (0.001s)
>>> ...
>>> [1]: testCJK[1] (0.000s)
>>> ...
>>> [135] testCJK[135]
>>>
>>> the only tests that failed were the localized methods like the date
>>> stuff, where its going to create an 'expected' localized string and then
>>> compare against that.
>>> it makes me suspect that somehow there is some race, and the default
>>> locale is actually changing as the test is running, or something crazy like
>>> this?!
>>>
>>>
>>>
>>> On Thu, Dec 10, 2009 at 3:23 PM, Erick Erickson <erickerickson@gmail.com
>>> > wrote:
>>>
>>>> Yep, that sure makes me nervous too. I've never seen a failure in
>>>> IntelliJ or from a
>>>> shell window.
>>>>
>>>> How often do you need to run it to see an error? And what language is it
>>>> using?
>>>> And what test?
>>>>
>>>> I can try this in my IntelliJ setup and see if I can reproduce it. Note
>>>> I'm running
>>>> on a Macbook Pro...
>>>>
>>>> I wonder if a repeating script would show an intermittent error........
>>>>
>>>> Erick
>>>>
>>>>
>>>> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>>>
>>>>>
>>>>> [
>>>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>>>>>
>>>>> Robert Muir commented on LUCENE-2122:
>>>>> -------------------------------------
>>>>>
>>>>> Hi Erick, I played with this patch some and (not intentionally trying)
>>>>> I would get random test failures for TestQueryParser under eclipse... its
>>>>> not really something I am able to repeat though.
>>>>>
>>>>> maybe some race condition (I do not know how eclipse executes
>>>>> parameterized tests).... ?
>>>>>
>>>>> if it is a problem with my IDE that is one thing, just makes me a
>>>>> little nervous right now. trying to think what could cause this....
>>>>>
>>>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>>>> deriving from LocalizedTestCase
>>>>> >
>>>>> ---------------------------------------------------------------------------------------------------
>>>>> >
>>>>> > Key: LUCENE-2122
>>>>> > URL:
>>>>> https://issues.apache.org/jira/browse/LUCENE-2122
>>>>> > Project: Lucene - Java
>>>>> > Issue Type: Improvement
>>>>> > Components: Other
>>>>> > Affects Versions: 3.1
>>>>> > Reporter: Erick Erickson
>>>>> > Assignee: Robert Muir
>>>>> > Priority: Minor
>>>>> > Fix For: 3.1
>>>>> >
>>>>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>>>>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>>>>> >
>>>>> >
>>>>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>>>>> testing of Locales.
>>>>>
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> -
>>>>> You can reply to this email to add a comment to the issue online.
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Robert Muir
>>> rcmuir@gmail.com
>>>
>>
>>
>
--
Robert Muir
rcmuir@gmail.com
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
So I ran this test suite from Idea a dozen times or so and no problem.
Then I ran it a couple of thousand times through Ant via a shell
script. No problem.
So I'm tending toward thinking it's an Eclipse issue, what do
you think?
Erick
On Thu, Dec 10, 2009 at 4:23 PM, Erick Erickson <er...@gmail.com>wrote:
> I'll give this a whirl tonight. The reason I was wondering what language
> is to insure that my machine *also* tests the offending locale.....
>
> A bit of a nit, the flaw in the approach with LocalizedTestCase is
> that *every* test in the class is run against *all* locales......
> To change this, as I understand it, we'd need to break the tests
> out into a separate class.......
>
> Intermittent errors often smell like a race condition, so I'll be
> on the lookout for one.
>
> But I also wonder if you'd ever get this error running outside
> of Eclipse.
>
> I really, really, really hate ones like this. Let's say you have a script
> that runs 1,000 times flawlessly from the shell. What does that prove?
> <nasty grin>.
>
> But maybe if I relentlessly press the test button on that class it'll
> happen
> to me too....
>
> FWIW
> Erick
>
> On Thu, Dec 10, 2009 at 3:30 PM, Robert Muir <rc...@gmail.com> wrote:
>
>> i just right clicked TestQueryParser and said 'run as junit test'
>>
>> i could not tell which locales failed, (just testing your original patch,
>> no modifications)
>> the way they are shown instead is like an array of 135 elements...
>> [0]: testCJK[0] (0.000s)
>> testSimple[0] (0.001s)
>> ...
>> [1]: testCJK[1] (0.000s)
>> ...
>> [135] testCJK[135]
>>
>> the only tests that failed were the localized methods like the date stuff,
>> where its going to create an 'expected' localized string and then compare
>> against that.
>> it makes me suspect that somehow there is some race, and the default
>> locale is actually changing as the test is running, or something crazy like
>> this?!
>>
>>
>>
>> On Thu, Dec 10, 2009 at 3:23 PM, Erick Erickson <er...@gmail.com>wrote:
>>
>>> Yep, that sure makes me nervous too. I've never seen a failure in
>>> IntelliJ or from a
>>> shell window.
>>>
>>> How often do you need to run it to see an error? And what language is it
>>> using?
>>> And what test?
>>>
>>> I can try this in my IntelliJ setup and see if I can reproduce it. Note
>>> I'm running
>>> on a Macbook Pro...
>>>
>>> I wonder if a repeating script would show an intermittent error........
>>>
>>> Erick
>>>
>>>
>>> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>>
>>>>
>>>> [
>>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>>>>
>>>> Robert Muir commented on LUCENE-2122:
>>>> -------------------------------------
>>>>
>>>> Hi Erick, I played with this patch some and (not intentionally trying) I
>>>> would get random test failures for TestQueryParser under eclipse... its not
>>>> really something I am able to repeat though.
>>>>
>>>> maybe some race condition (I do not know how eclipse executes
>>>> parameterized tests).... ?
>>>>
>>>> if it is a problem with my IDE that is one thing, just makes me a little
>>>> nervous right now. trying to think what could cause this....
>>>>
>>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>>> deriving from LocalizedTestCase
>>>> >
>>>> ---------------------------------------------------------------------------------------------------
>>>> >
>>>> > Key: LUCENE-2122
>>>> > URL:
>>>> https://issues.apache.org/jira/browse/LUCENE-2122
>>>> > Project: Lucene - Java
>>>> > Issue Type: Improvement
>>>> > Components: Other
>>>> > Affects Versions: 3.1
>>>> > Reporter: Erick Erickson
>>>> > Assignee: Robert Muir
>>>> > Priority: Minor
>>>> > Fix For: 3.1
>>>> >
>>>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>>>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>>>> >
>>>> >
>>>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>>>> testing of Locales.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> You can reply to this email to add a comment to the issue online.
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>
>>
>> --
>> Robert Muir
>> rcmuir@gmail.com
>>
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
I'll give this a whirl tonight. The reason I was wondering what language
is to insure that my machine *also* tests the offending locale.....
A bit of a nit, the flaw in the approach with LocalizedTestCase is
that *every* test in the class is run against *all* locales......
To change this, as I understand it, we'd need to break the tests
out into a separate class.......
Intermittent errors often smell like a race condition, so I'll be
on the lookout for one.
But I also wonder if you'd ever get this error running outside
of Eclipse.
I really, really, really hate ones like this. Let's say you have a script
that runs 1,000 times flawlessly from the shell. What does that prove?
<nasty grin>.
But maybe if I relentlessly press the test button on that class it'll happen
to me too....
FWIW
Erick
On Thu, Dec 10, 2009 at 3:30 PM, Robert Muir <rc...@gmail.com> wrote:
> i just right clicked TestQueryParser and said 'run as junit test'
>
> i could not tell which locales failed, (just testing your original patch,
> no modifications)
> the way they are shown instead is like an array of 135 elements...
> [0]: testCJK[0] (0.000s)
> testSimple[0] (0.001s)
> ...
> [1]: testCJK[1] (0.000s)
> ...
> [135] testCJK[135]
>
> the only tests that failed were the localized methods like the date stuff,
> where its going to create an 'expected' localized string and then compare
> against that.
> it makes me suspect that somehow there is some race, and the default locale
> is actually changing as the test is running, or something crazy like this?!
>
>
>
> On Thu, Dec 10, 2009 at 3:23 PM, Erick Erickson <er...@gmail.com>wrote:
>
>> Yep, that sure makes me nervous too. I've never seen a failure in IntelliJ
>> or from a
>> shell window.
>>
>> How often do you need to run it to see an error? And what language is it
>> using?
>> And what test?
>>
>> I can try this in my IntelliJ setup and see if I can reproduce it. Note
>> I'm running
>> on a Macbook Pro...
>>
>> I wonder if a repeating script would show an intermittent error........
>>
>> Erick
>>
>>
>> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>>>
>>> Robert Muir commented on LUCENE-2122:
>>> -------------------------------------
>>>
>>> Hi Erick, I played with this patch some and (not intentionally trying) I
>>> would get random test failures for TestQueryParser under eclipse... its not
>>> really something I am able to repeat though.
>>>
>>> maybe some race condition (I do not know how eclipse executes
>>> parameterized tests).... ?
>>>
>>> if it is a problem with my IDE that is one thing, just makes me a little
>>> nervous right now. trying to think what could cause this....
>>>
>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>> deriving from LocalizedTestCase
>>> >
>>> ---------------------------------------------------------------------------------------------------
>>> >
>>> > Key: LUCENE-2122
>>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>>> > Project: Lucene - Java
>>> > Issue Type: Improvement
>>> > Components: Other
>>> > Affects Versions: 3.1
>>> > Reporter: Erick Erickson
>>> > Assignee: Robert Muir
>>> > Priority: Minor
>>> > Fix For: 3.1
>>> >
>>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>>> >
>>> >
>>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>>> testing of Locales.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Robert Muir <rc...@gmail.com>.
i just right clicked TestQueryParser and said 'run as junit test'
i could not tell which locales failed, (just testing your original patch, no
modifications)
the way they are shown instead is like an array of 135 elements...
[0]: testCJK[0] (0.000s)
testSimple[0] (0.001s)
...
[1]: testCJK[1] (0.000s)
...
[135] testCJK[135]
the only tests that failed were the localized methods like the date stuff,
where its going to create an 'expected' localized string and then compare
against that.
it makes me suspect that somehow there is some race, and the default locale
is actually changing as the test is running, or something crazy like this?!
On Thu, Dec 10, 2009 at 3:23 PM, Erick Erickson <er...@gmail.com>wrote:
> Yep, that sure makes me nervous too. I've never seen a failure in IntelliJ
> or from a
> shell window.
>
> How often do you need to run it to see an error? And what language is it
> using?
> And what test?
>
> I can try this in my IntelliJ setup and see if I can reproduce it. Note I'm
> running
> on a Macbook Pro...
>
> I wonder if a repeating script would show an intermittent error........
>
> Erick
>
>
> On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>>
>> Robert Muir commented on LUCENE-2122:
>> -------------------------------------
>>
>> Hi Erick, I played with this patch some and (not intentionally trying) I
>> would get random test failures for TestQueryParser under eclipse... its not
>> really something I am able to repeat though.
>>
>> maybe some race condition (I do not know how eclipse executes
>> parameterized tests).... ?
>>
>> if it is a problem with my IDE that is one thing, just makes me a little
>> nervous right now. trying to think what could cause this....
>>
>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>> deriving from LocalizedTestCase
>> >
>> ---------------------------------------------------------------------------------------------------
>> >
>> > Key: LUCENE-2122
>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>> > Project: Lucene - Java
>> > Issue Type: Improvement
>> > Components: Other
>> > Affects Versions: 3.1
>> > Reporter: Erick Erickson
>> > Assignee: Robert Muir
>> > Priority: Minor
>> > Fix For: 3.1
>> >
>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>> >
>> >
>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>> testing of Locales.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
--
Robert Muir
rcmuir@gmail.com
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Yep, that sure makes me nervous too. I've never seen a failure in IntelliJ
or from a
shell window.
How often do you need to run it to see an error? And what language is it
using?
And what test?
I can try this in my IntelliJ setup and see if I can reproduce it. Note I'm
running
on a Macbook Pro...
I wonder if a repeating script would show an intermittent error........
Erick
On Thu, Dec 10, 2009 at 3:10 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> Hi Erick, I played with this patch some and (not intentionally trying) I
> would get random test failures for TestQueryParser under eclipse... its not
> really something I am able to repeat though.
>
> maybe some race condition (I do not know how eclipse executes parameterized
> tests).... ?
>
> if it is a problem with my IDE that is one thing, just makes me a little
> nervous right now. trying to think what could cause this....
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Assignee: Robert Muir
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122-r4.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Siiiiggggh. I'll look at it again tonight....
On Wed, Dec 9, 2009 at 9:13 AM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788100#action_12788100]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> Hi Erick, in the Date tools test I think you can delete the public static
> Collection<Locale[]> data(), I think you might have accidentally included
> it?
>
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Assignee: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Robert Muir <rc...@gmail.com>.
thanks Erick, in this case we only need to worry about reporting failure, so
you know what locale your code does not work for.
for the other thing we can just run the default locale, then everything else
(including the default). This is how the current code works. The main thing
is that for example, if you are French and you write some date code that is
completely broken, its better to see the failure in your own locale before
you see a test failure in the Thai calendar or something like that.
On Wed, Dec 9, 2009 at 11:06 PM, Erick Erickson <er...@gmail.com>wrote:
> It's embarrassing that I had to poke around for 1/2 hour to find *code that
> I had written recently*. siiiggghhh. Maybe this time it'll stick....
>
> In LuceneTestCaseJ4, we added an @Rule-annotated class
> InterceptTestCaseEvents whose methods get called whenever an "event"
> happens, things like succeeded, failed, started, etc.. The failed method
> looks for a method in the failing class called reportAdditionalFailureInfo.
> So by adding something like the below to LocalizedTestCase you can print any
> information you have available whenever things fail. It gets printed in
> addition to the usual information Junit prints. Warning: I tested this
> *very* lightly, at least it worked in the one case I tried..
>
> @Override
> public void reportAdditionalFailureInfo() {
> System.out.println("Failing locale is" +
> _currentLocale.getDisplayName(_origDefault));
> super.reportAdditionalFailureInfo(); // call to super.report.....
> UNTESTED! and probably not necessary in this context. Left as an exercise
> for the reader <G>.
> }
>
> Currently this is only does extra stuff for failed cases, but it would be
> trivial to extend for start, end, succeeded whenever there's a need.
>
> Your second question seems quite do-able,just by putting the default locale
> in the list before getting into the loop as the first entry. I'm not sure
> removing the default language is worth the effort, so it gets run twice. But
> if you're writing the code, do whatever you want.
>
> Gotta get some sleep <G>...
>
> Erick
>
>
> On Wed, Dec 9, 2009 at 9:45 PM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788455#action_12788455]
>>
>> Robert Muir commented on LUCENE-2122:
>> -------------------------------------
>>
>> thanks Erick, i will play around with the patch some, generally just
>> double-check the locale stuff is doing what we want, looks like it will.
>>
>> i havent tested yet, but looking at the code i have a few questions (i can
>> try to add these to the patch just curious what you think):
>> 1. if a test fails under some locale, say th_TH, will junit 4 attempt to
>> print this parameter out in some way so I know that it failed? If not do you
>> know of a hack?
>> 2. i am thinking about reordering the locale array so that it tests the
>> default one first. if you are trying to do some test-driven dev it might be
>> strange if the test fails under a different locale first. I think this one
>> is obvious, I will play with it to see how it behaves now.
>>
>>
>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>> deriving from LocalizedTestCase
>> >
>> ---------------------------------------------------------------------------------------------------
>> >
>> > Key: LUCENE-2122
>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>> > Project: Lucene - Java
>> > Issue Type: Improvement
>> > Components: Other
>> > Affects Versions: 3.1
>> > Reporter: Erick Erickson
>> > Assignee: Robert Muir
>> > Priority: Minor
>> > Fix For: 3.1
>> >
>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>> LUCENE-2122-r4.patch, LUCENE-2122.patch
>> >
>> >
>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>> testing of Locales.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
--
Robert Muir
rcmuir@gmail.com
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
It's embarrassing that I had to poke around for 1/2 hour to find *code that
I had written recently*. siiiggghhh. Maybe this time it'll stick....
In LuceneTestCaseJ4, we added an @Rule-annotated class
InterceptTestCaseEvents whose methods get called whenever an "event"
happens, things like succeeded, failed, started, etc.. The failed method
looks for a method in the failing class called reportAdditionalFailureInfo.
So by adding something like the below to LocalizedTestCase you can print any
information you have available whenever things fail. It gets printed in
addition to the usual information Junit prints. Warning: I tested this
*very* lightly, at least it worked in the one case I tried..
@Override
public void reportAdditionalFailureInfo() {
System.out.println("Failing locale is" +
_currentLocale.getDisplayName(_origDefault));
super.reportAdditionalFailureInfo(); // call to super.report.....
UNTESTED! and probably not necessary in this context. Left as an exercise
for the reader <G>.
}
Currently this is only does extra stuff for failed cases, but it would be
trivial to extend for start, end, succeeded whenever there's a need.
Your second question seems quite do-able,just by putting the default locale
in the list before getting into the loop as the first entry. I'm not sure
removing the default language is worth the effort, so it gets run twice. But
if you're writing the code, do whatever you want.
Gotta get some sleep <G>...
Erick
On Wed, Dec 9, 2009 at 9:45 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788455#action_12788455]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> thanks Erick, i will play around with the patch some, generally just
> double-check the locale stuff is doing what we want, looks like it will.
>
> i havent tested yet, but looking at the code i have a few questions (i can
> try to add these to the patch just curious what you think):
> 1. if a test fails under some locale, say th_TH, will junit 4 attempt to
> print this parameter out in some way so I know that it failed? If not do you
> know of a hack?
> 2. i am thinking about reordering the locale array so that it tests the
> default one first. if you are trying to do some test-driven dev it might be
> strange if the test fails under a different locale first. I think this one
> is obvious, I will play with it to see how it behaves now.
>
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Assignee: Robert Muir
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122-r4.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
<<<its possible the problems are not reproduceable because
they are a crazy problem with these tests.>>>
Agree absolutely. I was just making sure we considered
the *possibility* that the paramaterized version was showing
an underlying Lucene problem rather than assuming the
fault was with Junit4. Having spent a way too much of
my programming life being absolutely sure I knew what
part of the system was causing the failure only to find that
the problem was waaay over *there* instead, I'm kinda
sensitive that way <G>...
I'll eagerly await your results...
Erick
On Sun, Dec 13, 2009 at 5:24 PM, Robert Muir <rc...@gmail.com> wrote:
> Erick it might be a gremlin on my computer or my brain...
> also i think i was inadvertently using different JVM's for running ant test
> (sometimes java 5/64bit sometimes 6/32bit). this is because i was doing
> something with forrest and changed my JAVA_HOME in one shell window.
>
> so i'm going to run 100 ant clean tests with each JVM, logging to a file.
> if these work reliably then I think I will conclude I was doing something
> stupid before... (like forgot to ant clean or something like that)
>
> this computer is windows, so you are right it might have different locales
> than your mac.
>
> however, i think we should consider your last comment: its possible the
> problems are not reproduceable because they are a crazy problem with these
> tests.
> for example, i think we should be extra cautious and call Calendar.clear()
> on all our calendars before changing time values and then asserting expected
> results.
> I don't see any obvious problem though, just thinking if something based on
> the 'current time' was affecting the tests, then this might make it hard to
> reproduce.
>
>
> On Sat, Dec 12, 2009 at 9:26 PM, Erick Erickson <er...@gmail.com>wrote:
>
>> Hmmmm, you can't get either patch to work reliably.
>> On the other hand, I can't get either patch to fail.
>> I ran the whole ant clean test thing half a dozen times.
>> I'll make a script to loop all night tonight and we'll see.
>> I also ran just the TestQueryParser around 700 times
>> from Ant via a shell script. No problems. No problems
>> in IntelliJ. Siiggghhh.
>>
>> Anybody else want to try applying either patch and see
>> what happens? I'd hate to lose the capabilities of the
>> Parameterized tests because of a gremlin that only exists
>> on Robert's machine. I'd also hate to introduce "cool new
>> capabilities" that started training us to ignore test failures.
>> That's bad. Very bad.
>>
>> Robert: What kind of machine are you running on? I'm running
>> on a Macbook Pro...
>>
>> As it stands, I'm not sure whether parameterized tests are
>> the issue or whether the issue is Locale testing. Or whether
>> Robert has some peculiar setup. Or, for that matter, whether
>> I have some peculiar setup that makes it work by hiding an
>> instability. It sure would be nice to figure out where the
>> fragility is before relying on Parameterized tests...
>>
>> Robert:
>> If you have the patience, could you try your patch out and
>> capture the failure? I'm especially curious if your patch
>> fails on the same language every time. Who knows? On
>> your machine, this *could* be hitting an edge case, that's
>> actually a flaw in the code somewhere rather than an artifact
>> of the test framework. I don't even know if my machine
>> is using all of the same Locale's as yours....
>>
>> I'd have at figuring out what was going on, but I can't make
>> it fail. "It works on my machine" doesn't leave me very many
>> directions forward....
>>
>> But I'm sooooo glad that Robert is finding this nonsense
>> *before* we get too much farther down this road rather than
>> after....
>>
>> I'll poke around on the internet and see if there's anything there
>> that I can see.
>>
>> Erick
>>
>>
>> On Sat, Dec 12, 2009 at 8:55 AM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>>
>>> Robert Muir updated LUCENE-2122:
>>> --------------------------------
>>>
>>> Assignee: (was: Robert Muir)
>>>
>>> i am unassigning in case someone else can figure this one out, at my wits
>>> end here :)
>>> perhaps its just something wierd about my environment or something
>>>
>>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>>> deriving from LocalizedTestCase
>>> >
>>> ---------------------------------------------------------------------------------------------------
>>> >
>>> > Key: LUCENE-2122
>>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>>> > Project: Lucene - Java
>>> > Issue Type: Improvement
>>> > Components: Other
>>> > Affects Versions: 3.1
>>> > Reporter: Erick Erickson
>>> > Priority: Minor
>>> > Fix For: 3.1
>>> >
>>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>>> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>>> >
>>> >
>>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>>> testing of Locales.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>
>
> --
> Robert Muir
> rcmuir@gmail.com
>
Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Robert Muir <rc...@gmail.com>.
Erick it might be a gremlin on my computer or my brain...
also i think i was inadvertently using different JVM's for running ant test
(sometimes java 5/64bit sometimes 6/32bit). this is because i was doing
something with forrest and changed my JAVA_HOME in one shell window.
so i'm going to run 100 ant clean tests with each JVM, logging to a file.
if these work reliably then I think I will conclude I was doing something
stupid before... (like forgot to ant clean or something like that)
this computer is windows, so you are right it might have different locales
than your mac.
however, i think we should consider your last comment: its possible the
problems are not reproduceable because they are a crazy problem with these
tests.
for example, i think we should be extra cautious and call Calendar.clear()
on all our calendars before changing time values and then asserting expected
results.
I don't see any obvious problem though, just thinking if something based on
the 'current time' was affecting the tests, then this might make it hard to
reproduce.
On Sat, Dec 12, 2009 at 9:26 PM, Erick Erickson <er...@gmail.com>wrote:
> Hmmmm, you can't get either patch to work reliably.
> On the other hand, I can't get either patch to fail.
> I ran the whole ant clean test thing half a dozen times.
> I'll make a script to loop all night tonight and we'll see.
> I also ran just the TestQueryParser around 700 times
> from Ant via a shell script. No problems. No problems
> in IntelliJ. Siiggghhh.
>
> Anybody else want to try applying either patch and see
> what happens? I'd hate to lose the capabilities of the
> Parameterized tests because of a gremlin that only exists
> on Robert's machine. I'd also hate to introduce "cool new
> capabilities" that started training us to ignore test failures.
> That's bad. Very bad.
>
> Robert: What kind of machine are you running on? I'm running
> on a Macbook Pro...
>
> As it stands, I'm not sure whether parameterized tests are
> the issue or whether the issue is Locale testing. Or whether
> Robert has some peculiar setup. Or, for that matter, whether
> I have some peculiar setup that makes it work by hiding an
> instability. It sure would be nice to figure out where the
> fragility is before relying on Parameterized tests...
>
> Robert:
> If you have the patience, could you try your patch out and
> capture the failure? I'm especially curious if your patch
> fails on the same language every time. Who knows? On
> your machine, this *could* be hitting an edge case, that's
> actually a flaw in the code somewhere rather than an artifact
> of the test framework. I don't even know if my machine
> is using all of the same Locale's as yours....
>
> I'd have at figuring out what was going on, but I can't make
> it fail. "It works on my machine" doesn't leave me very many
> directions forward....
>
> But I'm sooooo glad that Robert is finding this nonsense
> *before* we get too much farther down this road rather than
> after....
>
> I'll poke around on the internet and see if there's anything there
> that I can see.
>
> Erick
>
>
> On Sat, Dec 12, 2009 at 8:55 AM, Robert Muir (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Robert Muir updated LUCENE-2122:
>> --------------------------------
>>
>> Assignee: (was: Robert Muir)
>>
>> i am unassigning in case someone else can figure this one out, at my wits
>> end here :)
>> perhaps its just something wierd about my environment or something
>>
>> > Use JUnit4 capabilites for more thorough Locale testing for classes
>> deriving from LocalizedTestCase
>> >
>> ---------------------------------------------------------------------------------------------------
>> >
>> > Key: LUCENE-2122
>> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
>> > Project: Lucene - Java
>> > Issue Type: Improvement
>> > Components: Other
>> > Affects Versions: 3.1
>> > Reporter: Erick Erickson
>> > Priority: Minor
>> > Fix For: 3.1
>> >
>> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
>> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>> >
>> >
>> > Use the @Parameterized capabilities of Junit4 to allow more extensive
>> testing of Locales.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
--
Robert Muir
rcmuir@gmail.com
Re: [jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Hmmmm, you can't get either patch to work reliably.
On the other hand, I can't get either patch to fail.
I ran the whole ant clean test thing half a dozen times.
I'll make a script to loop all night tonight and we'll see.
I also ran just the TestQueryParser around 700 times
from Ant via a shell script. No problems. No problems
in IntelliJ. Siiggghhh.
Anybody else want to try applying either patch and see
what happens? I'd hate to lose the capabilities of the
Parameterized tests because of a gremlin that only exists
on Robert's machine. I'd also hate to introduce "cool new
capabilities" that started training us to ignore test failures.
That's bad. Very bad.
Robert: What kind of machine are you running on? I'm running
on a Macbook Pro...
As it stands, I'm not sure whether parameterized tests are
the issue or whether the issue is Locale testing. Or whether
Robert has some peculiar setup. Or, for that matter, whether
I have some peculiar setup that makes it work by hiding an
instability. It sure would be nice to figure out where the
fragility is before relying on Parameterized tests...
Robert:
If you have the patience, could you try your patch out and
capture the failure? I'm especially curious if your patch
fails on the same language every time. Who knows? On
your machine, this *could* be hitting an edge case, that's
actually a flaw in the code somewhere rather than an artifact
of the test framework. I don't even know if my machine
is using all of the same Locale's as yours....
I'd have at figuring out what was going on, but I can't make
it fail. "It works on my machine" doesn't leave me very many
directions forward....
But I'm sooooo glad that Robert is finding this nonsense
*before* we get too much farther down this road rather than
after....
I'll poke around on the internet and see if there's anything there
that I can see.
Erick
On Sat, Dec 12, 2009 at 8:55 AM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Robert Muir updated LUCENE-2122:
> --------------------------------
>
> Assignee: (was: Robert Muir)
>
> i am unassigning in case someone else can figure this one out, at my wits
> end here :)
> perhaps its just something wierd about my environment or something
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Uwe:
Thanks, I'll remember that in the future....
On Sun, Dec 13, 2009 at 5:31 AM, Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi Erick,
>
>
>
> sadly, the eMail reply to JIRA issues does not work for mails sent to this
> mailing list (because the list overrides reply-to header so JIRA does not
> get the answer). If you answer only on the ML, we loss those comments in the
> issue.
>
>
>
> Uwe
>
>
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
> ------------------------------
>
> *From:* Erick Erickson [mailto:erickerickson@gmail.com]
> *Sent:* Sunday, December 13, 2009 4:02 AM
> *To:* java-dev@lucene.apache.org
> *Subject:* Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for
> more thorough Locale testing for classes deriving from LocalizedTestCase
>
>
>
> Robert:
>
> The -r4 patch runs for you and you want me to look at your patch compared
> to r4? Sure, I'll do that, but not til tomorrow, I do much better work when
> I'm not tired <G>.....
>
> I confess I haven't looked at your patch beyond installing it to see if I
> could reproduce the failure (looks like our emails crossed). But it's
> *still* peculiar that it behaves differently between our two machines. OTOH,
> maybe your patch will fail on my machine sometime tonight, my 4 successes
> aren't very statistically significant after all..
>
> Erick
>
> On Sat, Dec 12, 2009 at 9:14 PM, Robert Muir (JIRA) <ji...@apache.org>
> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789837#action_12789837]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> btw, I left 'ant clean test' running in a loop and just checked it with
> this patch, no problems.
> so perhaps its my own incompetence. Erick can you take a look? Do you see
> some obvious problem?
>
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
>
RE: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi Erick,
sadly, the eMail reply to JIRA issues does not work for mails sent to this
mailing list (because the list overrides reply-to header so JIRA does not
get the answer). If you answer only on the ML, we loss those comments in the
issue.
Uwe
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
_____
From: Erick Erickson [mailto:erickerickson@gmail.com]
Sent: Sunday, December 13, 2009 4:02 AM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Robert:
The -r4 patch runs for you and you want me to look at your patch compared to
r4? Sure, I'll do that, but not til tomorrow, I do much better work when I'm
not tired <G>.....
I confess I haven't looked at your patch beyond installing it to see if I
could reproduce the failure (looks like our emails crossed). But it's
*still* peculiar that it behaves differently between our two machines. OTOH,
maybe your patch will fail on my machine sometime tonight, my 4 successes
aren't very statistically significant after all..
Erick
On Sat, Dec 12, 2009 at 9:14 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
[
https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.pl
ugin.system.issuetabpanels:comment-tabpanel
<https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.p
lugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789837#actio
n_12789837> &focusedCommentId=12789837#action_12789837 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
btw, I left 'ant clean test' running in a loop and just checked it with this
patch, no problems.
so perhaps its my own incompetence. Erick can you take a look? Do you see
some obvious problem?
> Use JUnit4 capabilites for more thorough Locale testing for classes
deriving from LocalizedTestCase
>
----------------------------------------------------------------------------
-----------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive
testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Robert:
The -r4 patch runs for you and you want me to look at your patch compared to
r4? Sure, I'll do that, but not til tomorrow, I do much better work when I'm
not tired <G>.....
I confess I haven't looked at your patch beyond installing it to see if I
could reproduce the failure (looks like our emails crossed). But it's
*still* peculiar that it behaves differently between our two machines. OTOH,
maybe your patch will fail on my machine sometime tonight, my 4 successes
aren't very statistically significant after all..
Erick
On Sat, Dec 12, 2009 at 9:14 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789837#action_12789837]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> btw, I left 'ant clean test' running in a loop and just checked it with
> this patch, no problems.
> so perhaps its my own incompetence. Erick can you take a look? Do you see
> some obvious problem?
>
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch,
> LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: [jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by Erick Erickson <er...@gmail.com>.
Hmmm, you're probably right. There's no earthly
reason for a test writer to create an instance
of LocalizedTestCase, it has no use except as
a superclass by its nature even though it has
no abstract methods. So making it abstract will
server to flag that fact to anyone who tries
to instantiate it.
I'll change this too, hold off on applying this patch,
I'll wait for a bit to gather more comments and put
them all together in an r3 version.
Erick
On Sun, Dec 6, 2009 at 9:02 PM, Robert Muir (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786757#action_12786757]
>
> Robert Muir commented on LUCENE-2122:
> -------------------------------------
>
> Erick do you think LocalizedTestCase should be abstract?
>
> > Use JUnit4 capabilites for more thorough Locale testing for classes
> deriving from LocalizedTestCase
> >
> ---------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-2122
> > URL: https://issues.apache.org/jira/browse/LUCENE-2122
> > Project: Lucene - Java
> > Issue Type: Improvement
> > Components: Other
> > Affects Versions: 3.1
> > Reporter: Erick Erickson
> > Assignee: Erick Erickson
> > Priority: Minor
> > Fix For: 3.1
> >
> > Attachments: LUCENE-2122-r2.patch, LUCENE-2122.patch
> >
> >
> > Use the @Parameterized capabilities of Junit4 to allow more extensive
> testing of Locales.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2122:
--------------------------------
Attachment: LUCENE-2122.patch
Hi Erick, I spent some time with this patch today and here is what happened:
1. i tried to simplify localizedtestcase, so that it works just like the old one, with the exception of using junit4 parameterized facility.
2. i wrote some bad tests and ensured things worked well such as error messages, default locale being run first, etc etc.
3. i had everything good to go when i got random failures again, this time from 'ant clean test' about 3 times (pass,fail,pass)
(sorry i should have done something to capture each test log but i did not)
because the only real change here is use of the parameterized facility (the logic is the same), it makes me think that we should stick with .runBare() for the time being, because there is something strange going on here and I'm not even trying to break it.
attached is the modified version of your patch.
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788100#action_12788100 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
Hi Erick, in the Date tools test I think you can delete the public static Collection<Locale[]> data(), I think you might have accidentally included it?
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794629#action_12794629 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
Erick the test problems havent gone away (see latest hudson failure), but as you can see they appear to be unrelated to your patch, but existing problems.
I am glad Uwe and Hudson are now seeing the failures I saw, but unfortunately I am unable to reproduce this problem. I think it is very wierd that it only recently has started happening and the Junit 4 jar file is looking very suspicious to me :)
The next step is to force another test failure (with existing trunk code), except with an additional assertion in TestQueryParser.getParser(), that asserts that the created queryparser has the same Locale as LocalizedTestcase.locale
If this assertion is not triggered, and a failure happens anyway, then there is no problem with LocalizedTestCase and we should commit your patch. This would mean the problem is instead some problem in the query parser, its tests, date calculations, jvm handling of thai dates, something else, but not the locale-switching.
if the assertion is triggered, then we need to figure how why before changing the locale-swapping mechanism.
I ran this test 2500 times last night but i couldnt make it fail. i have a very small portable right now and I will need to wait till the new year to really look at this more...
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reassigned LUCENE-2122:
-----------------------------------
Assignee: Robert Muir (was: Erick Erickson)
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2122:
--------------------------------
Assignee: (was: Robert Muir)
i am unassigning in case someone else can figure this one out, at my wits end here :)
perhaps its just something wierd about my environment or something
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-2122:
-----------------------------------
Attachment: LUCENE-2122-r2.patch
Restoring original default Locale after test class has been run.
Thanks Robert!
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794635#action_12794635 ]
Uwe Schindler commented on LUCENE-2122:
---------------------------------------
Some additional infos about the Hudson failure:
In the past Hudson used an internal junit.jar to do the testing, which was in version 4 (the exact version can only be found out by one with hudson access, Mike?). So Hudson was always using Junit4 for testing even in Lucene 2.9. After the clover updates, we removed this JUnit lib path from the ANT command line and therefore also hudson uses 4.7 as shipped with the svn checkout.
If it is really a JUnit problem, it seems to only occur with version 4.7. But I am not sure, I still stink it may be a thread starvation problem (slow test) or some local time problem that occurred two nights ago.
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788455#action_12788455 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
thanks Erick, i will play around with the patch some, generally just double-check the locale stuff is doing what we want, looks like it will.
i havent tested yet, but looking at the code i have a few questions (i can try to add these to the patch just curious what you think):
1. if a test fails under some locale, say th_TH, will junit 4 attempt to print this parameter out in some way so I know that it failed? If not do you know of a hack?
2. i am thinking about reordering the locale array so that it tests the default one first. if you are trying to do some test-driven dev it might be strange if the test fails under a different locale first. I think this one is obvious, I will play with it to see how it behaves now.
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-2122:
-----------------------------------
Attachment: LUCENE-2122-r4.patch
OK, I plead advanced senility or some other excuse for the last patch.
Robert:
Thanks so much for looking this over, I have no clue what I was thinking with the TestDateTools. Or the other classes that derive from LocalizedTestCase.
The @Parameterized and @RunWith only needed to be in LocalizedTestCase and all the inheriting classes just rely on the base class to collect the different locales.
Anyway, this one should be much better....
Erick
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-2122:
-----------------------------------
Attachment: LUCENE-2122.patch
All tests pass. This modifies all test classes (core and contrib) that derive from LocalizedTestCase. LocalizedTestCase now tests all test methods in all derived classes against all available Locales.
If we want some of the tests to NOT run against all locales, we'd need to refactor them into their own test class....
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786749#action_12786749 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
Hi Erick, I am a little nervous about the change to LocalizedTestCase.tearDown() here.
I think we must restore the users default Locale, since its a JRE-system wide global thing and we are changing it on the fly here.
this was stashed away here before:
{code}
/**
* Before changing the default Locale, save the default Locale here so that it
* can be restored.
*/
private final Locale defaultLocale = Locale.getDefault();
{code}
and restored in tearDown()... otherwise strange things could happen, such as your IDE could go bonkers after running the tests! (but maybe I am missing something)
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788884#action_12788884 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
Hi Erick, I played with this patch some and (not intentionally trying) I would get random test failures for TestQueryParser under eclipse... its not really something I am able to repeat though.
maybe some race condition (I do not know how eclipse executes parameterized tests).... ?
if it is a problem with my IDE that is one thing, just makes me a little nervous right now. trying to think what could cause this....
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794471#action_12794471 ]
Erick Erickson commented on LUCENE-2122:
----------------------------------------
Robert:
Where are we on this? Last I knew your test problems had disappeared, but memory can be tricky....
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786757#action_12786757 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
Erick do you think LocalizedTestCase should be abstract?
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789837#action_12789837 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
btw, I left 'ant clean test' running in a loop and just checked it with this patch, no problems.
so perhaps its my own incompetence. Erick can you take a look? Do you see some obvious problem?
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794639#action_12794639 ]
Robert Muir commented on LUCENE-2122:
-------------------------------------
I would be curious to know the previous version of the junit jar file that Hudson was using, if anyone can figure this out.
I do not want to quickly blame junit or jvm, etc, but its very suspicious that this only recently started happening, and only sporadically for thai locale with the query parser.
this will be a tricky one to figure out for sure.
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122-r4.patch, LUCENE-2122.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2122) Use JUnit4 capabilites for more
thorough Locale testing for classes deriving from LocalizedTestCase
Posted by "Erick Erickson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated LUCENE-2122:
-----------------------------------
Attachment: LUCENE-2122-r3.patch
Made LocalizedTestCase abstract...
> Use JUnit4 capabilites for more thorough Locale testing for classes deriving from LocalizedTestCase
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2122
> URL: https://issues.apache.org/jira/browse/LUCENE-2122
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Affects Versions: 3.1
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2122-r2.patch, LUCENE-2122-r3.patch, LUCENE-2122.patch
>
>
> Use the @Parameterized capabilities of Junit4 to allow more extensive testing of Locales.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org