You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/08 08:30:03 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2383: [Feature][st-engine] Add user-defined class loader
TyrantLucifer opened a new pull request, #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
#2345
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1208857032
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1208866652
The classloader should implement child first logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1208857741
cc @Hisoka-X @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1208882777
If we implement child first logic, we should discuss which classes should be loaded by the parent, I think this is a topic we can discuss in community meeting at tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1210159288
> > If we implement child first logic, we should discuss which classes should be loaded by the parent, I think this is a topic we can discuss in community meeting at tonight.
>
> Agree with you
Do we have anly conclusions about this discussion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1211789302
@EricJoy2048 @Hisoka-X pls review, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1210160151
> > > If we implement child first logic, we should discuss which classes should be loaded by the parent, I think this is a topic we can discuss in community meeting at tonight.
> >
> >
> > Agree with you
>
> Do we have any conclusions about this discussion?
The `org.apache.seatunnel` should alway load by parent, other use child first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2383: [Feature][st-engine] Add user-defined class loader
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2383:
URL: https://github.com/apache/incubator-seatunnel/pull/2383#issuecomment-1208883192
> If we implement child first logic, we should discuss which classes should be loaded by the parent, I think this is a topic we can discuss in community meeting at tonight.
Agree with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org