You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/10 03:31:10 UTC
[GitHub] [beam] udim opened a new pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
udim opened a new pull request #11966:
URL: https://github.com/apache/beam/pull/11966
For Python 3.6+, CALL_FUNCTION doesn't try to simulate Any.
For Python 3.7+, LOAD_METHOD returns Any for builtin methods, since they
don't disassemble into bytecode.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-644279994
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
tvalentyn merged pull request #11966:
URL: https://github.com/apache/beam/pull/11966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-645005519
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642797987
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-644403235
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642175471
> Seeing a failure in PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not sure if related.
https://issues.apache.org/jira/browse/BEAM-8878
> The change LGTM and verified that it addresses [[BEAM-10217](https://issues.apache.org/jira/browse/BEAM-10217)]. Would it make sense to add this test: [91d6469#diff-f14ce51d033ed4ff23353402681571ecR195](https://github.com/apache/beam/commit/91d6469e05b61df0bb19f2442b159129ea8ddeef#diff-f14ce51d033ed4ff23353402681571ecR195) ?
Thanks for that test. I did use it to figure out the core issue. However I think the test in this PR more precisely tests the issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642205856
> Jenkins hooks are mad at me.
Dependencies are still broken so it won't help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642164503
Seeing a failure in PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not sure if related.
The change LGTM and verified that it addresses [BEAM-10217]. Would it make sense to add this test: https://github.com/apache/beam/pull/11954/commits/91d6469e05b61df0bb19f2442b159129ea8ddeef#diff-f14ce51d033ed4ff23353402681571ecR195 ?
If so I can add a commit to your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] udim commented on pull request #11966: [BEAM-10217] CALL_FUNCTION and CALL_METHOD fixes
Posted by GitBox <gi...@apache.org>.
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-641700067
R: @tvalentyn
CC: @saavan-google-intern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org