You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/02 17:02:03 UTC

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1865: [SCB-2031] Fix mapping problem between pojo consumer method and provider swagger operation

wujimin commented on a change in pull request #1865:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1865#discussion_r449153654



##########
File path: providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/definition/PojoConsumerMeta.java
##########
@@ -33,7 +34,7 @@
 
   private SchemaMeta schemaMeta;
 
-  private Map<String, PojoConsumerOperationMeta> operationMetas = new HashMap<>();
+  private Map<Method, PojoConsumerOperationMeta> operationMetas = new HashMap<>();

Review comment:
       Method to be key of HashMap is too expensive  
   should change HashMap to IdentityHashMap




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org