You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/11 17:40:51 UTC
[GitHub] [tvm] janetsc opened a new pull request, #13040: [Hexagon] Remove setting CMAKE_CXX_COMPILER for Hexagon
janetsc opened a new pull request, #13040:
URL: https://github.com/apache/tvm/pull/13040
Remove the setting for CMAKE_CXX_COMPILER for Hexagon as it is causing errors on docker builds on shared systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #13040: [Hexagon] Remove setting CMAKE_CXX_COMPILER for Hexagon
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #13040:
URL: https://github.com/apache/tvm/pull/13040#discussion_r992735082
##########
tests/scripts/task_config_build_hexagon.sh:
##########
@@ -28,7 +28,6 @@ echo set\(USE_RPC ON\) >> config.cmake
echo set\(USE_MICRO ON\) >> config.cmake
echo set\(USE_MICRO_STANDALONE_RUNTIME ON\) >> config.cmake
echo set\(USE_LLVM "${CLANG_LLVM_HOME}/bin/llvm-config"\) >> config.cmake
-echo set\(CMAKE_CXX_COMPILER "/opt/sccache/clang++"\) >> config.cmake
Review Comment:
It'd be fine to take this out, a bunch of people have had problems with it when running locally, but it should still stay on in CI. AFAIK all scripts that run in Jenkins during CI have the env variable `CI` set to `true`, could you switch on that and set `CMAKE_CXX_COMPILER` if that's the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] janetsc commented on a diff in pull request #13040: [Hexagon] Remove setting CMAKE_CXX_COMPILER for Hexagon
Posted by GitBox <gi...@apache.org>.
janetsc commented on code in PR #13040:
URL: https://github.com/apache/tvm/pull/13040#discussion_r992761071
##########
tests/scripts/task_config_build_hexagon.sh:
##########
@@ -28,7 +28,6 @@ echo set\(USE_RPC ON\) >> config.cmake
echo set\(USE_MICRO ON\) >> config.cmake
echo set\(USE_MICRO_STANDALONE_RUNTIME ON\) >> config.cmake
echo set\(USE_LLVM "${CLANG_LLVM_HOME}/bin/llvm-config"\) >> config.cmake
-echo set\(CMAKE_CXX_COMPILER "/opt/sccache/clang++"\) >> config.cmake
Review Comment:
I’m going to cancel this - I was just going an experiment. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] janetsc closed pull request #13040: [Hexagon] Remove setting CMAKE_CXX_COMPILER for Hexagon
Posted by GitBox <gi...@apache.org>.
janetsc closed pull request #13040: [Hexagon] Remove setting CMAKE_CXX_COMPILER for Hexagon
URL: https://github.com/apache/tvm/pull/13040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org