You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/10 17:49:53 UTC

[GitHub] [pulsar] ZiyaoWei opened a new pull request, #16012: Add comment for using `configurationMetadataStoreUrl` instead of `configurationStoreServers`

ZiyaoWei opened a new pull request, #16012:
URL: https://github.com/apache/pulsar/pull/16012

   ### Motivation
   
   #13777 deprecated `zookeeperServers` and `configurationStoreServers`. However, while the former has comments pointing to `metadataStoreUrl` which should be used instead, the latter doesn't have comments about which field to use instead.
   
   ### Modifications
   
   Add comments that point users to `configurationMetadataStoreUrl`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   Need to update docs? 
     
   - [ ] `doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #16012: Add comment for using `configurationMetadataStoreUrl` instead of `configurationStoreServers`

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #16012:
URL: https://github.com/apache/pulsar/pull/16012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16012: Add comment for using `configurationMetadataStoreUrl` instead of `configurationStoreServers`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16012:
URL: https://github.com/apache/pulsar/pull/16012#issuecomment-1152599147

   @ZiyaoWei:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16012: Add comment for using `configurationMetadataStoreUrl` instead of `configurationStoreServers`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16012:
URL: https://github.com/apache/pulsar/pull/16012#issuecomment-1152599107

   @ZiyaoWei:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org