[GitHub] [airflow] snjypl commented on a diff in pull request #23720: Fix backfill queued task getting reset to scheduled state.

[GitBox <gi...@apache.org>]

snjypl commented on code in PR #23720:
URL: https://github.com/apache/airflow/pull/23720#discussion_r879714440


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -530,13 +532,15 @@ def start(self) -> None:
             self.kube_config.worker_pods_pending_timeout_check_interval,
             self._check_worker_pods_pending_timeout,
         )
-        self.event_scheduler.call_regular_interval(
-            self.kube_config.worker_pods_queued_check_interval,
-            self.clear_not_launched_queued_tasks,
-        )
-        # We also call this at startup as that's the most likely time to see
-        # stuck queued tasks
-        self.clear_not_launched_queued_tasks()
+
+        if self.job_id != 'manual':

Review Comment:
   to me it seemed like, for `manual` the `ti.queued_by_job_id` is not updated, it remains same as the original job_id. 
   
   and also, in this case the executor.job_id is str, and ti.queued_by_job_id is expected to the an integer.  so the query in `clear_not_launched_queued_tasks` will fail. 
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org