You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/20 11:55:00 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
JiriOndrusek opened a new pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549
Closes https://github.com/apache/camel-quarkus/issues/1471
As a part of the solution extension-support/bouncycastle was created. Bouncy castle security provider is required for camel-as2 and without proper initialization there are no digests working with quarkus in native.
Replaces https://github.com/apache/camel-quarkus/pull/1488
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473999326
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
@jamesnetherton
Locally it worked without whitelisting, but in build log for this PR, I ss:
`[error]: Build step org.apache.camel.quarkus.component.support.policy.deployment.PolicyProcessor#bannedReflectiveClasses threw an exception: java.lang.IllegalStateException: The following classes should either be whitelisted via an UnbannedReflectiveBuildItem or they should not be registered for reflection via ReflectiveClassBuildItem: [org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration, org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r474029484
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
@JiriOndrusek if you rebase on the latest work from `camel-master`, it should work for you now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r474002774
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
I didn't probably understood your previous comment correctly. To be sure:
- I have to fix reason of failed reflection for camel classes
- I can remove registration for reflection for camel, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r474003780
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
Urgh! Sorry for the confusion. I forgot I have not committed the crucial part that removes the policy extension yet.
Let me do on the camel-master branch ASAP and your changes should work ok afterwards. I'll ping you when it's done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473960613
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
I should have also added that in Camel 3.5, you no longer have to register the various `EndpointConfiguration` classes for reflection. So that part can be removed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678235446
Thanks, @JiriOndrusek !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473922419
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
Thanks for the suggestion. I'll look into option of fixing problem in its root in camel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473923271
##########
File path: pom.xml
##########
@@ -46,6 +46,7 @@
<awssdk1.version>1.11.714</awssdk1.version>
<awssdk1-swf-libs.version>1.11.22</awssdk1-swf-libs.version>
<awssdk2.version>2.13.58</awssdk2.version>
+ <bouncycastle.version>1.65</bouncycastle.version>
Review comment:
yes, I agree. I'll change version of bouncycastle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678139792
I think the failure is caused by the fact that you have some stale files in `docs` that were produced by the old version of the tooling (that we upgraded recently) and the new version of the tooling does not like them. So please try the following:
* Remove all files your PR has added to `docs` module
* Rebuild the whole tree `mvn clean install -DskipTests -Denforcer.skip -Dquarkus.build.skip`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473918097
##########
File path: pom.xml
##########
@@ -46,6 +46,7 @@
<awssdk1.version>1.11.714</awssdk1.version>
<awssdk1-swf-libs.version>1.11.22</awssdk1-swf-libs.version>
<awssdk2.version>2.13.58</awssdk2.version>
+ <bouncycastle.version>1.65</bouncycastle.version>
Review comment:
Camel master has moved on to `1.66` so we should align with that.
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
You shouldn't need to whitelist Camel configuration classes with Camel 3.5. The issues behind it should be fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473989802
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
I've removed it. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#discussion_r473999326
##########
File path: extensions/as2/deployment/src/main/java/org/apache/camel/quarkus/component/as2/deployment/As2Processor.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.as2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.CombinedIndexBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.IndexDependencyBuildItem;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+import org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration;
+import org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration;
+import org.apache.camel.component.as2.api.util.AS2Utils;
+import org.apache.camel.quarkus.component.as2.As2Recorder;
+import org.apache.camel.quarkus.core.deployment.spi.UnbannedReflectiveBuildItem;
+import org.jboss.jandex.IndexView;
+
+class As2Processor {
+
+ private static final String FEATURE = "camel-as2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitializedClasses() {
+ return new RuntimeInitializedClassBuildItem(AS2Utils.class.getCanonicalName());
+ }
+
+ @BuildStep
+ UnbannedReflectiveBuildItem whitelistConfigurationClasses() {
+ return new UnbannedReflectiveBuildItem(
Review comment:
@jamesnetherton
Locally it worked without whitelisting, but in build log for this PR, I see:
`[error]: Build step org.apache.camel.quarkus.component.support.policy.deployment.PolicyProcessor#bannedReflectiveClasses threw an exception: java.lang.IllegalStateException: The following classes should either be whitelisted via an UnbannedReflectiveBuildItem or they should not be registered for reflection via ReflectiveClassBuildItem: [org.apache.camel.component.as2.AS2ClientManagerEndpointConfiguration, org.apache.camel.component.as2.AS2ServerManagerEndpointConfiguration]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek edited a comment on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek edited a comment on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678144511
Thanks @ppalaga. I've removed this file some time ago, but probably I've introduced it back during rebase. Current build is executed without this doc file.
IMHO it would be nice if this error could happen also locally - I'm not sure why it didn't fail during local build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678118872
Should pass the CI. But it fails with:
` Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (antora-xref-check) on project camel-quarkus-docs: Command execution failed.: Process exited with an error: 1 (Exit value: 1)`
@jamesnetherton , @ppalaga do you know, what could be wrong? (Local build is working correctly and generated docs seems to be correct)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678233329
Good to merge from my point of view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678144511
@ppalaga I've noticed this, but I wasn't sure whether it could cause current problem. Current build is executed without this doc file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1549: Add Camel AS2 Modules as Quarkus Extension #1471
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1549:
URL: https://github.com/apache/camel-quarkus/pull/1549#issuecomment-678140712
> * Remove all files your PR has added to `docs` module
Esp. this one `docs/modules/ROOT/pages/extensions/as2.adoc`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org