You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/06/08 09:22:56 UTC
[GitHub] [dolphinscheduler] JinyLeeChina opened a new pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
JinyLeeChina opened a new pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602
api module #5498
sub task #5499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#issuecomment-859198999
There is an error in mockito. It is a usage error. It is better to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#issuecomment-859199112
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs merged pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wen-hemin commented on a change in pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
wen-hemin commented on a change in pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#discussion_r648062048
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -232,23 +239,26 @@ public Result verifyProcessDefinitionName(@ApiIgnore @RequestAttribute(value = C
public Result updateProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectName", value = "PROJECT_NAME", required = true) @PathVariable String projectName,
@RequestParam(value = "name", required = true) String name,
- @RequestParam(value = "id", required = true) int id,
- @RequestParam(value = "processDefinitionJson", required = true) String processDefinitionJson,
- @RequestParam(value = "locations", required = false) String locations,
- @RequestParam(value = "connects", required = false) String connects,
+ @RequestParam(value = "code", required = true) long code,
@RequestParam(value = "description", required = false) String description,
Review comment:
Field need to be preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on a change in pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#discussion_r648896409
##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2240,6 +2303,7 @@ public int saveProcessDefinition(User operator, Project project, String name, St
/**
* save processDefinition
*/
+ @Deprecated
Review comment:
If we upgrate new api, i think this can be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wen-hemin commented on a change in pull request #5602: [Feature][JsonSplit-api] api of processDefinition create/update
Posted by GitBox <gi...@apache.org>.
wen-hemin commented on a change in pull request #5602:
URL: https://github.com/apache/dolphinscheduler/pull/5602#discussion_r648076227
##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -2240,6 +2303,7 @@ public int saveProcessDefinition(User operator, Project project, String name, St
/**
* save processDefinition
*/
+ @Deprecated
Review comment:
Is this method unnecessary?
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -232,23 +239,26 @@ public Result verifyProcessDefinitionName(@ApiIgnore @RequestAttribute(value = C
public Result updateProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectName", value = "PROJECT_NAME", required = true) @PathVariable String projectName,
@RequestParam(value = "name", required = true) String name,
- @RequestParam(value = "id", required = true) int id,
- @RequestParam(value = "processDefinitionJson", required = true) String processDefinitionJson,
- @RequestParam(value = "locations", required = false) String locations,
- @RequestParam(value = "connects", required = false) String connects,
+ @RequestParam(value = "code", required = true) long code,
@RequestParam(value = "description", required = false) String description,
Review comment:
Field need to be preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org