You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Daniel Pitts (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 23:05:10 UTC
[jira] [Created] (OGNL-29) Replace "getValueBody" and
"setValueBody" methods with visitor pattern.
Replace "getValueBody" and "setValueBody" methods with visitor pattern.
-----------------------------------------------------------------------
Key: OGNL-29
URL: https://issues.apache.org/jira/browse/OGNL-29
Project: OGNL
Issue Type: Improvement
Reporter: Daniel Pitts
Attachments: Get_Set_Value_Body_visitors.patch
I've made yet another patch which cleans up the AST code even further. Please inspect carefully before committing, as this moves around a lot of the core functionality. It may also add some overhead to some of the "setValue" use-cases. I'm not sure if that is acceptable or not, even though the overhead is likely to be extremely small.
Patch to come...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-29) Replace "getValueBody" and
"setValueBody" methods with visitor pattern.
Posted by "Daniel Pitts (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Pitts updated OGNL-29:
-----------------------------
Attachment: Get_Set_Value_Body_visitors.patch
Attaching patch which will replace getValueBody and setValueBody with visitor pattern.
> Replace "getValueBody" and "setValueBody" methods with visitor pattern.
> -----------------------------------------------------------------------
>
> Key: OGNL-29
> URL: https://issues.apache.org/jira/browse/OGNL-29
> Project: OGNL
> Issue Type: Improvement
> Reporter: Daniel Pitts
> Attachments: Get_Set_Value_Body_visitors.patch
>
>
> I've made yet another patch which cleans up the AST code even further. Please inspect carefully before committing, as this moves around a lot of the core functionality. It may also add some overhead to some of the "setValue" use-cases. I'm not sure if that is acceptable or not, even though the overhead is likely to be extremely small.
> Patch to come...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira