[jira] [Commented] (PDFBOX-5199) Possible memory leak after calling decode filter

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349740#comment-17349740 ] 

ASF subversion and git services commented on PDFBOX-5199:
---------------------------------------------------------

Commit 1890103 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1890103 ]

PDFBOX-5199: avoid possible memory leak

> Possible memory leak after calling decode filter
> ------------------------------------------------
>
>                 Key: PDFBOX-5199
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-5199
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 2.0.23
>            Reporter: Tilman Hausherr
>            Priority: Minor
>             Fix For: 2.0.24, 3.0.0 PDFBox
>
>
> valerybokov noticed in PR#107 that filters are sometimes closed and sometimes not
> {quote}
> IdentityFilter and CCITTFaxFilter extends Filter
> IdentityFilter.encode(InputStream, OutputStream, COSDictionary). The InputStream will not be closed.
> CCITTFaxFilter.encode(InputStream, OutputStream, COSDictionary). The InputStream will be closed.
> The input parameter will not be closed if an exception is thrown.
> {quote}
> My understanding is that the caller should close streams unless the javadoc tell something else. So I did search a bit, and found places in COSStream and PDStream where this isn't done. Any close in filter should be removed.
> I also searched for encode but there I found that the caller closes properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org