You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/03/21 20:02:07 UTC
Review Request: Remove almost all remaining uses of MESOS_HOME
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs
-----
src/tests/external_tests.cpp 21fa705
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/launcher/launcher.cpp 98a4847
src/launcher/launcher.hpp 221094f
src/deploy/mesos-env.sh 9f93a41
src/deploy/mesos-daemon 2e75d04
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/common/logging.cpp 9e346f2
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/launcher/launcher.cpp, line 215
> > <https://reviews.apache.org/r/4434/diff/2/?file=94280#file94280line215>
> >
> > s/frameworksHome/configuration option 'frameworks_home'
Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
On 2012-03-23 16:36:06, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4434/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 16:36:06)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> Removes most remaining uses of MESOS_HOME from the tree.
>
> Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
>
> After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
>
>
> This addresses bug MESOS-85.
> https://issues.apache.org/jira/browse/MESOS-85
>
>
> Diffs
> -----
>
> src/common/logging.cpp 9e346f2
> src/configurator/configurator.hpp a3a104f
> src/configurator/configurator.cpp 2666e50
> src/deploy/mesos-daemon 2e75d04
> src/deploy/mesos-env.sh 9f93a41
> src/launcher/launcher.hpp 221094f
> src/launcher/launcher.cpp 98a4847
> src/launcher/main.cpp 5c55ace
> src/local/main.cpp d4b68a9
> src/master/main.cpp a8fadc9
> src/mesos/main.cpp bbdb981
> src/sched/sched.cpp 16770a1
> src/slave/lxc_isolation_module.cpp 8c25dd4
> src/slave/main.cpp ac780c4
> src/slave/process_based_isolation_module.cpp e0f3ee8
> src/slave/slave.cpp 9332caa
> src/slave/webui.cpp 9f45442
> src/tests/configurator_tests.cpp 662e01f
> src/tests/external_tests.cpp 21fa705
>
> Diff: https://reviews.apache.org/r/4434/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Charles Reiss <wo...@gmail.com>.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/common/logging.cpp, lines 76-81
> > <https://reviews.apache.org/r/4434/diff/2/?file=94274#file94274line76>
> >
> > This all becomes:
> > return conf.get("log_dir", "");
> >
> > Also, is it okay to return an empty log dir!?
Yes; empty uses the glog default.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/configurator/configurator.hpp, line 296
> > <https://reviews.apache.org/r/4434/diff/2/?file=94275#file94275line296>
> >
> > As long as you're in this file, please kill these white spaces.
Done.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/configurator/configurator.hpp, line 302
> > <https://reviews.apache.org/r/4434/diff/2/?file=94275#file94275line302>
> >
> > And here.
Done. (And elsewhere.)
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/launcher/launcher.cpp, lines 223-225
> > <https://reviews.apache.org/r/4434/diff/2/?file=94280#file94280line223>
> >
> > Not your bug, but the '\' should not be necessary. Please kill them. Also, s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'.
Done and done.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/slave/slave.cpp, lines 1449-1461
> > <https://reviews.apache.org/r/4434/diff/2/?file=94289#file94289line1449>
> >
> > This all becomes:
> > string workDir = conf.get("work_dir", "work");
Done.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/slave/webui.cpp, lines 43-55
> > <https://reviews.apache.org/r/4434/diff/2/?file=94290#file94290line43>
> >
> > Same as above.
Done.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/tests/configurator_tests.cpp, line 70
> > <https://reviews.apache.org/r/4434/diff/2/?file=94291#file94291line70>
> >
> > Kill whitespace.
Done.
> On 2012-03-23 04:55:13, Benjamin Hindman wrote:
> > src/tests/configurator_tests.cpp, line 262
> > <https://reviews.apache.org/r/4434/diff/2/?file=94291#file94291line262>
> >
> > Remove extra spaces.
Done.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
On 2012-03-23 06:04:06, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4434/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 06:04:06)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> Removes most remaining uses of MESOS_HOME from the tree.
>
> Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
>
> After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
>
>
> This addresses bug MESOS-85.
> https://issues.apache.org/jira/browse/MESOS-85
>
>
> Diffs
> -----
>
> src/common/logging.cpp 9e346f2
> src/configurator/configurator.hpp a3a104f
> src/configurator/configurator.cpp 2666e50
> src/deploy/mesos-daemon 2e75d04
> src/deploy/mesos-env.sh 9f93a41
> src/launcher/launcher.hpp 221094f
> src/launcher/launcher.cpp 98a4847
> src/launcher/main.cpp 5c55ace
> src/local/main.cpp d4b68a9
> src/master/main.cpp a8fadc9
> src/mesos/main.cpp bbdb981
> src/sched/sched.cpp 16770a1
> src/slave/lxc_isolation_module.cpp 8c25dd4
> src/slave/main.cpp ac780c4
> src/slave/process_based_isolation_module.cpp e0f3ee8
> src/slave/slave.cpp 9332caa
> src/slave/webui.cpp 9f45442
> src/tests/configurator_tests.cpp 662e01f
> src/tests/external_tests.cpp 21fa705
>
> Diff: https://reviews.apache.org/r/4434/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
I do want to get this committed, but when I was looking a little closer there are a few cleanups to make first.
src/common/logging.cpp
<https://reviews.apache.org/r/4434/#comment13503>
This all becomes:
return conf.get("log_dir", "");
Also, is it okay to return an empty log dir!?
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13579>
As long as you're in this file, please kill these white spaces.
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13580>
And here.
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13504>
s/frameworksHome/configuration option 'frameworks_home'
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13581>
Not your bug, but the '\' should not be necessary. Please kill them. Also, s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'.
src/slave/slave.cpp
<https://reviews.apache.org/r/4434/#comment13582>
This all becomes:
string workDir = conf.get("work_dir", "work");
src/slave/webui.cpp
<https://reviews.apache.org/r/4434/#comment13506>
Same as above.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13584>
Kill whitespace.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13509>
Remove extra spaces.
- Benjamin
On 2012-03-21 19:02:07, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4434/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 19:02:07)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> Removes most remaining uses of MESOS_HOME from the tree.
>
> Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
>
> After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
>
>
> This addresses bug MESOS-85.
> https://issues.apache.org/jira/browse/MESOS-85
>
>
> Diffs
> -----
>
> src/tests/external_tests.cpp 21fa705
> src/slave/slave.cpp 9332caa
> src/slave/webui.cpp 9f45442
> src/tests/configurator_tests.cpp 662e01f
> src/sched/sched.cpp 16770a1
> src/slave/lxc_isolation_module.cpp 8c25dd4
> src/slave/main.cpp ac780c4
> src/slave/process_based_isolation_module.cpp e0f3ee8
> src/master/main.cpp a8fadc9
> src/mesos/main.cpp bbdb981
> src/launcher/main.cpp 5c55ace
> src/local/main.cpp d4b68a9
> src/launcher/launcher.cpp 98a4847
> src/launcher/launcher.hpp 221094f
> src/deploy/mesos-env.sh 9f93a41
> src/deploy/mesos-daemon 2e75d04
> src/configurator/configurator.hpp a3a104f
> src/configurator/configurator.cpp 2666e50
> src/common/logging.cpp 9e346f2
>
> Diff: https://reviews.apache.org/r/4434/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6246
-----------------------------------------------------------
Ship it!
This is brilliant! Thanks Charles!
- Benjamin
On 2012-03-21 19:02:07, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4434/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 19:02:07)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> Removes most remaining uses of MESOS_HOME from the tree.
>
> Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
>
> After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
>
>
> This addresses bug MESOS-85.
> https://issues.apache.org/jira/browse/MESOS-85
>
>
> Diffs
> -----
>
> src/tests/external_tests.cpp 21fa705
> src/slave/slave.cpp 9332caa
> src/slave/webui.cpp 9f45442
> src/tests/configurator_tests.cpp 662e01f
> src/sched/sched.cpp 16770a1
> src/slave/lxc_isolation_module.cpp 8c25dd4
> src/slave/main.cpp ac780c4
> src/slave/process_based_isolation_module.cpp e0f3ee8
> src/master/main.cpp a8fadc9
> src/mesos/main.cpp bbdb981
> src/launcher/main.cpp 5c55ace
> src/local/main.cpp d4b68a9
> src/launcher/launcher.cpp 98a4847
> src/launcher/launcher.hpp 221094f
> src/deploy/mesos-env.sh 9f93a41
> src/deploy/mesos-daemon 2e75d04
> src/configurator/configurator.hpp a3a104f
> src/configurator/configurator.cpp 2666e50
> src/common/logging.cpp 9e346f2
>
> Diff: https://reviews.apache.org/r/4434/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6326
-----------------------------------------------------------
Ship it!
Thanks Charles, I'm committing this now.
- Benjamin
On 2012-03-23 16:36:06, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4434/
> -----------------------------------------------------------
>
> (Updated 2012-03-23 16:36:06)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Summary
> -------
>
> Removes most remaining uses of MESOS_HOME from the tree.
>
> Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
>
> After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
>
>
> This addresses bug MESOS-85.
> https://issues.apache.org/jira/browse/MESOS-85
>
>
> Diffs
> -----
>
> src/common/logging.cpp 9e346f2
> src/configurator/configurator.hpp a3a104f
> src/configurator/configurator.cpp 2666e50
> src/deploy/mesos-daemon 2e75d04
> src/deploy/mesos-env.sh 9f93a41
> src/launcher/launcher.hpp 221094f
> src/launcher/launcher.cpp 98a4847
> src/launcher/main.cpp 5c55ace
> src/local/main.cpp d4b68a9
> src/master/main.cpp a8fadc9
> src/mesos/main.cpp bbdb981
> src/sched/sched.cpp 16770a1
> src/slave/lxc_isolation_module.cpp 8c25dd4
> src/slave/main.cpp ac780c4
> src/slave/process_based_isolation_module.cpp e0f3ee8
> src/slave/slave.cpp 9332caa
> src/slave/webui.cpp 9f45442
> src/tests/configurator_tests.cpp 662e01f
> src/tests/external_tests.cpp 21fa705
>
> Diff: https://reviews.apache.org/r/4434/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
(Updated 2012-03-23 16:36:06.443788)
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs (updated)
-----
src/common/logging.cpp 9e346f2
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/deploy/mesos-daemon 2e75d04
src/deploy/mesos-env.sh 9f93a41
src/launcher/launcher.hpp 221094f
src/launcher/launcher.cpp 98a4847
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/tests/external_tests.cpp 21fa705
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles
Re: Review Request: Remove almost all remaining uses of MESOS_HOME
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/
-----------------------------------------------------------
(Updated 2012-03-23 06:04:06.888041)
Review request for mesos and Benjamin Hindman.
Summary
-------
Removes most remaining uses of MESOS_HOME from the tree.
Includes updates to the deploy scripts, but does not fix the deploy scripts (since mesos-getconf still won't exist).
After this patch, the remaining uses of MESOS_HOME I'm aware of are in the EC2 scripts.
This addresses bug MESOS-85.
https://issues.apache.org/jira/browse/MESOS-85
Diffs (updated)
-----
src/common/logging.cpp 9e346f2
src/configurator/configurator.hpp a3a104f
src/configurator/configurator.cpp 2666e50
src/deploy/mesos-daemon 2e75d04
src/deploy/mesos-env.sh 9f93a41
src/launcher/launcher.hpp 221094f
src/launcher/launcher.cpp 98a4847
src/launcher/main.cpp 5c55ace
src/local/main.cpp d4b68a9
src/master/main.cpp a8fadc9
src/mesos/main.cpp bbdb981
src/sched/sched.cpp 16770a1
src/slave/lxc_isolation_module.cpp 8c25dd4
src/slave/main.cpp ac780c4
src/slave/process_based_isolation_module.cpp e0f3ee8
src/slave/slave.cpp 9332caa
src/slave/webui.cpp 9f45442
src/tests/configurator_tests.cpp 662e01f
src/tests/external_tests.cpp 21fa705
Diff: https://reviews.apache.org/r/4434/diff
Testing
-------
make check
Thanks,
Charles