You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mpetruska <gi...@git.apache.org> on 2017/11/29 15:04:48 UTC
[GitHub] spark pull request #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find...
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19846
[SPARK-22393][SPARK-SHELL] spark-shell can't find imported types in class constructors, extends clause
## What changes were proposed in this pull request?
[SPARK-22393](https://issues.apache.org/jira/browse/SPARK-22393)
## How was this patch tested?
With a new test case in `RepSuite`
----
This code is a retrofit of the Scala [SI-9881](https://github.com/scala/bug/issues/9881) bug fix, which never made it into the Scala 2.11 branches. Pushing these changes directly to the Scala repo is not practical (see: https://github.com/scala/scala/pull/6195).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mpetruska/spark SPARK-22393
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19846.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19846
----
commit a5424274db54fde780154fbddeecab2c492a245d
Author: Mark Petruska <pe...@gmail.com>
Date: 2017-11-29T14:58:11Z
retrofits scala repl 2.11 bug fix (SI-9881) for Spark-shell
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
@HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix, which never made it to Scala 2.11. Instead of copy-pasting the original discussion, let me link the [original PR](https://github.com/scala/scala/pull/5640).
I can add more details about specific parts, of course.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19846
OK, so this just affects the Scala 2.11 REPL in Spark (good, because the 2.12 version works a little differently and the fix is already in 2.12), and you've just copied in the fixed classes and injected the fixed impl? sounds reasonable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19846
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
@srowen Yes, exactly. Tried to minimize the risks of any problems caused by this change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19846
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19846
@mpetruska, btw can you fill up the PR description about how it fixes?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19846
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19846
**[Test build #3998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit [`336446c`](https://github.com/apache/spark/commit/336446cb96d6d5985ec49d2c4643fae60d4c7007).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19846
**[Test build #3998 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3998/testReport)** for PR 19846 at commit [`336446c`](https://github.com/apache/spark/commit/336446cb96d6d5985ec49d2c4643fae60d4c7007).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19846: [SPARK-22393][SPARK-SHELL] spark-shell can't find import...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19846
Sorry, could not refactor the code better; since it makes heavy use of path-dependent types.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org