[GitHub] [airflow] kouk commented on a diff in pull request #23888: Support restricted index patterns in Elasticsearch log handler

[GitBox <gi...@apache.org>]

kouk commented on code in PR #23888:
URL: https://github.com/apache/airflow/pull/23888#discussion_r884425596


##########
airflow/config_templates/config.yml:
##########
@@ -2246,6 +2246,13 @@
       type: string
       example: ~
       default: "offset"
+    - name: index_patterns
+      description: |
+        Comma separated list of index patterns to use when searching for logs (default: `_all`).
+      version_added: 2.3.0
+      type: string
+      example: something-*
+      default: "_all"

Review Comment:
   @uranusjr indeed we could use `*`. According to the documentation it is equivalent to `_all`. See
   https://www.elastic.co/guide/en/elasticsearch/reference/8.2/search-search.html#search-search-api-path-params
   
   Initially I had it set to `*` and then changed it to `_all` because it seemed more readable. That said, I don't mind changing it back to `*` if ASF members prefer it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org