[jira] [Commented] (ARTEMIS-1980) Warn on failed check of table existence should be info

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627059#comment-16627059 ] 

ASF GitHub Bot commented on ARTEMIS-1980:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2181#discussion_r220121826
  
    --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java ---
    @@ -227,7 +227,11 @@ private void createTableIfNotExists(String tableName, String... sqls) throws SQL
                       }
                    }
                 } catch (SQLException e) {
    -               logger.warn(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
    +               if (logger.isDebugEnabled()) {
    +                  logger.debug(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
    +               } else {
    +                  logger.infof("Can't verify the initialization of table %s", tableName);
    --- End diff --
    
    I have missed what I should fix on this PR...it is providing a detailed log when DEBUG level is enabled, otherwise will just provide an info. That's because tends DB2 driver to scare users of weird errors when they are not errors at all...


> Warn on failed check of table existence should be info
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1980
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1980
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.6.2
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Trivial
>             Fix For: 2.7.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> DB2 metadata checks should erroneously report stale table existence on
> not existing/just deleted table, making the subsequent warning logs of failed
> SELECT COUNT useless and scaring: should be better to let them lowered to 
> INFO level, avoiding users log reporting tools (if any) to react to an expected behaviour.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)