You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/04/12 04:10:48 UTC
Re: Review Request 45955: Added CNI helper subcommand to
`mesos-containerizer`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45955/
-----------------------------------------------------------
(Updated April 12, 2016, 2:10 a.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Added a subcommand to `mesos-containerizer`.
Summary (updated)
-----------------
Added CNI helper subcommand to `mesos-containerizer`.
Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922
Repository: mesos
Description
-------
This will be used by the `network/cni` isolator to setup hostname and
various network files within the container UTS and mnt namespace.
Diffs (updated)
-----
src/slave/containerizer/mesos/main.cpp 63b257e5ea079d516c0cbed9593a116f22677255
Diff: https://reviews.apache.org/r/45955/diff/
Testing
-------
make
* Ran mesos-execute with the a single master/slave setup that the container attaches to the CNI network correctly and that its network files and hostname are setup correctly.
Thanks,
Avinash sridharan
Re: Review Request 45955: Added CNI helper subcommand to
`mesos-containerizer`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45955/#review128907
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 14, 2016, 3:24 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45955/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 3:24 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will be used by the `network/cni` isolator to setup hostname and
> various network files within the container UTS and mnt namespace.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/main.cpp 63b257e5ea079d516c0cbed9593a116f22677255
>
> Diff: https://reviews.apache.org/r/45955/diff/
>
>
> Testing
> -------
>
> make
>
> * Ran mesos-execute with the a single master/slave setup that the container attaches to the CNI network correctly and that its network files and hostname are setup correctly.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 45955: Added CNI helper subcommand to
`mesos-containerizer`.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45955/
-----------------------------------------------------------
(Updated April 14, 2016, 3:24 p.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Fixed a OSX build failure.
Bugs: MESOS-4922
https://issues.apache.org/jira/browse/MESOS-4922
Repository: mesos
Description
-------
This will be used by the `network/cni` isolator to setup hostname and
various network files within the container UTS and mnt namespace.
Diffs (updated)
-----
src/slave/containerizer/mesos/main.cpp 63b257e5ea079d516c0cbed9593a116f22677255
Diff: https://reviews.apache.org/r/45955/diff/
Testing
-------
make
* Ran mesos-execute with the a single master/slave setup that the container attaches to the CNI network correctly and that its network files and hostname are setup correctly.
Thanks,
Avinash sridharan
Re: Review Request 45955: Added CNI helper subcommand to
`mesos-containerizer`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45955/#review128810
-----------------------------------------------------------
This will break mac build. Please make sure to wrap code with ifdef linux
- Jie Yu
On April 12, 2016, 2:10 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45955/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 2:10 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-4922
> https://issues.apache.org/jira/browse/MESOS-4922
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will be used by the `network/cni` isolator to setup hostname and
> various network files within the container UTS and mnt namespace.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/main.cpp 63b257e5ea079d516c0cbed9593a116f22677255
>
> Diff: https://reviews.apache.org/r/45955/diff/
>
>
> Testing
> -------
>
> make
>
> * Ran mesos-execute with the a single master/slave setup that the container attaches to the CNI network correctly and that its network files and hostname are setup correctly.
>
>
> Thanks,
>
> Avinash sridharan
>
>