[GitHub] chetanmeh commented on a change in pull request #4186: Track activation counts in ContainerPool (not ContainerProxy)

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4186: Track activation counts in ContainerPool (not ContainerProxy)
URL: https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r249396163
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -112,7 +112,17 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
             // Schedule a job to a warm container
             ContainerPool
               .schedule(r.action, r.msg.user.namespace.name, freePool)
-              .map(container => (container, "warm"))
+              .map { container =>
+                val warmState = container._2 match {
 
 Review comment:
   Better to make state string part of `ContainerData` and here just delegate to that
   
   ```
    ContainerPool
                 .schedule(r.action, r.msg.user.namespace.name, freePool)
                 .map { case (container, data) => (container, data.state)}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services