You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/09/11 22:38:18 UTC
Review Request 25552: Show reason for PENDING state in Scheduler UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Bugs: AURORA-495
https://issues.apache.org/jira/browse/AURORA-495
Repository: aurora
Description
-------
Consumed the getPendingReason API call to add a message to any PENDING tasks.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
Diff: https://reviews.apache.org/r/25552/diff/
Testing
-------
./gradlew jsHint
Manual testing on local vagrant. Screenshots attached.
File Attachments
----------------
Screen Shot 2014-09-11 at 1.32.08 PM.png
https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
Thanks,
David McLaughlin
Re: Review Request 25552: Show reason for PENDING state in Scheduler
UI
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/#review53113
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 11, 2014, 8:38 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25552/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:38 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-495
> https://issues.apache.org/jira/browse/AURORA-495
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consumed the getPendingReason API call to add a message to any PENDING tasks.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
>
> Diff: https://reviews.apache.org/r/25552/diff/
>
>
> Testing
> -------
>
> ./gradlew jsHint
>
>
> Manual testing on local vagrant. Screenshots attached.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2014-09-11 at 1.32.08 PM.png
> https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 25552: Show reason for PENDING state in Scheduler
UI
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Sept. 11, 2014, 8:45 p.m., Joshua Cohen wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 90
> > <https://reviews.apache.org/r/25552/diff/1/?file=686507#file686507line90>
> >
> > I think this could just be:
> >
> > _.indexBy(reasons, 'taskId')
Good catch. Fixed.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/#review53106
-----------------------------------------------------------
On Sept. 11, 2014, 9:55 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25552/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:55 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-495
> https://issues.apache.org/jira/browse/AURORA-495
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consumed the getPendingReason API call to add a message to any PENDING tasks.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
>
> Diff: https://reviews.apache.org/r/25552/diff/
>
>
> Testing
> -------
>
> ./gradlew jsHint
>
>
> Manual testing on local vagrant. Screenshots attached.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2014-09-11 at 1.32.08 PM.png
> https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 25552: Show reason for PENDING state in Scheduler
UI
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/#review53106
-----------------------------------------------------------
Ship it!
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/25552/#comment92518>
I think this could just be:
_.indexBy(reasons, 'taskId')
- Joshua Cohen
On Sept. 11, 2014, 8:38 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25552/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 8:38 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-495
> https://issues.apache.org/jira/browse/AURORA-495
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consumed the getPendingReason API call to add a message to any PENDING tasks.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
>
> Diff: https://reviews.apache.org/r/25552/diff/
>
>
> Testing
> -------
>
> ./gradlew jsHint
>
>
> Manual testing on local vagrant. Screenshots attached.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2014-09-11 at 1.32.08 PM.png
> https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 25552: Show reason for PENDING state in Scheduler
UI
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/#review53123
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Sept. 11, 2014, 9:55 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25552/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:55 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-495
> https://issues.apache.org/jira/browse/AURORA-495
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consumed the getPendingReason API call to add a message to any PENDING tasks.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
>
> Diff: https://reviews.apache.org/r/25552/diff/
>
>
> Testing
> -------
>
> ./gradlew jsHint
>
>
> Manual testing on local vagrant. Screenshots attached.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2014-09-11 at 1.32.08 PM.png
> https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 25552: Show reason for PENDING state in Scheduler
UI
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25552/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 9:55 p.m.)
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Changes
-------
Simplified underscore accessor.
Bugs: AURORA-495
https://issues.apache.org/jira/browse/AURORA-495
Repository: aurora
Description
-------
Consumed the getPendingReason API call to add a message to any PENDING tasks.
Diffs (updated)
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js bfd360de45c75441743c8ba24a5c445f4146dba6
Diff: https://reviews.apache.org/r/25552/diff/
Testing
-------
./gradlew jsHint
Manual testing on local vagrant. Screenshots attached.
File Attachments
----------------
Screen Shot 2014-09-11 at 1.32.08 PM.png
https://reviews.apache.org/media/uploaded/files/2014/09/11/e44e3909-ad9b-4c4c-a3e6-6b6b3aedaa3c__Screen_Shot_2014-09-11_at_1.32.08_PM.png
Thanks,
David McLaughlin