You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 01:54:19 UTC

[GitHub] [spark] yaooqinn commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

yaooqinn commented on a change in pull request #32243:
URL: https://github.com/apache/spark/pull/32243#discussion_r616288139



##########
File path: sql/core/src/test/resources/tpcds-query-results/v1_4/q23b.sql.out
##########
@@ -3,7 +3,4 @@
 -- !query schema
 struct<c_last_name:string,c_first_name:string,sales:decimal(28,2)>
 -- !query output
-NULL	Robert              	598.86
-Brown                         	Monika              	6031.52
-Collins                       	Gordon              	727.57
-Green                         	Jesse               	9672.96
+

Review comment:
       Does the empty result set look right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org