You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/17 20:59:25 UTC
[GitHub] [arrow] kou opened a new pull request, #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
kou opened a new pull request, #35200:
URL: https://github.com/apache/arrow/pull/35200
### Rationale for this change
We must be able to use GoogleTest installed by vcpkg on Windows.
### What changes are included in this PR?
WIP
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512599929
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512679427
Revision: b93fcf279b34809866e0578ae461047bb62d529f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-483cb5f4bc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-483cb5f4bc)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/4730295767/jobs/8393819655)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512077391
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #35200:
URL: https://github.com/apache/arrow/pull/35200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512755369
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1515539459
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5c9a2149d3b34314a658ccc3676612d6...2ec8119fbf004f9b8b8fcd9b50c700ce/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512077336
* Closes: #35186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512700192
Revision: 75ee8ac71a4d44d56d12a9267ecfd8b92bce85f3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5d889aa63f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5d889aa63f)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/4730421626/jobs/8394110154)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1515539053
Benchmark runs are scheduled for baseline = a2548a79a191c280966d869c7778643fd64fdcd6 and contender = 9f852d46b95e00df5546847eccbe376eefcec857. 9f852d46b95e00df5546847eccbe376eefcec857 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48bf0165c20b40c78a89db44be49fc8c...aa36bad2758f4b8283f36cae1e2f6045/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4a0fdd7c7b1c45d0873263faad075711...bcf25b3f9104425b97ab3b3a5fd226ab/)
[Finished :arrow_down:4.59% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5c9a2149d3b34314a658ccc3676612d6...2ec8119fbf004f9b8b8fcd9b50c700ce/)
[Finished :arrow_down:0.24% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cbc10e5020ef45039a78710e0e12d860...7cecbacb719a4f1782d83767fa11bab7/)
Buildkite builds:
[Finished] [`9f852d46` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2740)
[Failed] [`9f852d46` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2774)
[Finished] [`9f852d46` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2738)
[Finished] [`9f852d46` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2765)
[Finished] [`a2548a79` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2739)
[Failed] [`a2548a79` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2773)
[Finished] [`a2548a79` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2737)
[Finished] [`a2548a79` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2764)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512080962
Revision: 082d9ff809b7c621def46d0956fdf124d7f0d1cc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-508b5c6527](https://github.com/ursacomputing/crossbow/branches/all?query=actions-508b5c6527)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/4725784440/jobs/8384617380)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512696611
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512676087
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35200: GH-35186: [CI][C++] Improve GoogleTest detection on Windows + vcpkg
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35200:
URL: https://github.com/apache/arrow/pull/35200#issuecomment-1512603337
Revision: ff555793a8c6102b8065f05b44cf262033514dfb
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0d78ffaf93](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0d78ffaf93)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/4729838377/jobs/8392796035)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org