[GitHub] [inlong] EMsnap commented on a diff in pull request #7937: [INLONG-7936][Manager] Support issued pulsar subscriptions to sort

["EMsnap (via GitHub)" <gi...@apache.org>]

EMsnap commented on code in PR #7937:
URL: https://github.com/apache/inlong/pull/7937#discussion_r1178761123


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/PulsarExtractNode.java:
##########
@@ -67,13 +69,15 @@ public PulsarExtractNode(@JsonProperty("id") String id,
             @Nullable @JsonProperty("watermarkField") WatermarkField watermarkField,
             @JsonProperty("properties") Map<String, String> properties,
             @Nonnull @JsonProperty("topic") String topic,
+            @JsonProperty("subscription") String subscription,

Review Comment:
   newly added parameter should be appended to the list 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org