You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/22 10:06:32 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #427:
feat: support ipv6
xujianhai666 opened a new pull request #427: feat: support ipv6
URL: https://github.com/apache/rocketmq-client-go/pull/427
- remove ipv4 check for nameserver
- add ipv6 check
CLoses #421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #427: feat:
support ipv6
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #427: feat: support ipv6
URL: https://github.com/apache/rocketmq-client-go/pull/427#issuecomment-589965162
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=h1) Report
> Merging [#427](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/8e6f902f3d90f659d9b1c9918030adb2b3cd1c36?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `76.92%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #427 +/- ##
========================================
+ Coverage 24.92% 25% +0.07%
========================================
Files 48 48
Lines 5476 5467 -9
========================================
+ Hits 1365 1367 +2
+ Misses 3924 3916 -8
+ Partials 187 184 -3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/namesrv.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/427/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbmFtZXNydi5nbw==) | `67.34% <ø> (+1.34%)` | :arrow_up: |
| [primitive/base.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/427/diff?src=pr&el=tree#diff-cHJpbWl0aXZlL2Jhc2UuZ28=) | `0% <ø> (-20%)` | :arrow_down: |
| [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/427/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `48.69% <ø> (ø)` | :arrow_up: |
| [internal/remote/tcp\_conn.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/427/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3RjcF9jb25uLmdv) | `60% <76.92%> (+10%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=footer). Last update [8e6f902...c4788b0](https://codecov.io/gh/apache/rocketmq-client-go/pull/427?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services