You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2024/11/01 01:50:42 UTC

Re: [PR] Support acknowledging a list of message IDs [pulsar-client-go]

BewareMyPower commented on PR #1301:
URL: https://github.com/apache/pulsar-client-go/pull/1301#issuecomment-2451142399

   @nodece I reused the tracking message ID's tracker and used the semantics that ACK on an incomplete message ID in the batch does not return an error. Please check the latest tests. As for reusing the `ackIDCommon` method. It's still hard. There is not much to reuse except for the `ack` method call on the tracking message ID. The `ack` and `ackWithTxn` methods of `unAckChunksTracker` are also a mess.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org