You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "liwei (JIRA)" <ji...@apache.org> on 2011/06/16 09:26:47 UTC
[jira] [Created] (THRIFT-1208) python TCompactProtocol.py writeBool
and readBool not follow the compact-proto-spec-2.txt spec for
CONTAINER_WRITE, CONTAINER_READ
python TCompactProtocol.py writeBool and readBool not follow the compact-proto-spec-2.txt spec for CONTAINER_WRITE, CONTAINER_READ
-----------------------------------------------------------------------------------------------------------------------------------
Key: THRIFT-1208
URL: https://issues.apache.org/jira/browse/THRIFT-1208
Project: Thrift
Issue Type: Bug
Components: Python - Library
Affects Versions: 0.6.1
Reporter: liwei
In https://issues.apache.org/jira/secure/attachment/12399869/compact-proto-spec-2.txt, define the boolean value as follow:
boolean-true => 0x1
boolean-false => 0x2
But in TCompactProtocol.py writeBool, readBool for CONTAINER_WRITE, CONTAINER_READ just bool(0x2) will always get true.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1208) python TCompactProtocol.py
writeBool and readBool not follow the compact-proto-spec-2.txt spec for
CONTAINER_WRITE, CONTAINER_READ
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064763#comment-13064763 ]
Hudson commented on THRIFT-1208:
--------------------------------
Integrated in Thrift #192 (See [https://builds.apache.org/job/Thrift/192/])
THRIFT-1208. py: Compact protocol always reads and writes booleans as true
Patch: liwei
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1146180
Files :
* /thrift/trunk/lib/py/src/protocol/TCompactProtocol.py
> python TCompactProtocol.py writeBool and readBool not follow the compact-proto-spec-2.txt spec for CONTAINER_WRITE, CONTAINER_READ
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1208
> URL: https://issues.apache.org/jira/browse/THRIFT-1208
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.6.1
> Reporter: liwei
> Assignee: liwei
> Fix For: 0.7
>
> Attachments: THRIFT-1208.compactproto_readwrite_bool_bug.patch
>
>
> In https://issues.apache.org/jira/secure/attachment/12399869/compact-proto-spec-2.txt, define the boolean value as follow:
> boolean-true => 0x1
> boolean-false => 0x2
> But in TCompactProtocol.py writeBool, readBool for CONTAINER_WRITE, CONTAINER_READ just bool(0x2) will always get true.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1208) python TCompactProtocol.py writeBool
and readBool not follow the compact-proto-spec-2.txt spec for
CONTAINER_WRITE, CONTAINER_READ
Posted by "liwei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
liwei updated THRIFT-1208:
--------------------------
Attachment: THRIFT-1208.compactproto_readwrite_bool_bug.patch
I upload the patch file
> python TCompactProtocol.py writeBool and readBool not follow the compact-proto-spec-2.txt spec for CONTAINER_WRITE, CONTAINER_READ
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1208
> URL: https://issues.apache.org/jira/browse/THRIFT-1208
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.6.1
> Reporter: liwei
> Attachments: THRIFT-1208.compactproto_readwrite_bool_bug.patch
>
>
> In https://issues.apache.org/jira/secure/attachment/12399869/compact-proto-spec-2.txt, define the boolean value as follow:
> boolean-true => 0x1
> boolean-false => 0x2
> But in TCompactProtocol.py writeBool, readBool for CONTAINER_WRITE, CONTAINER_READ just bool(0x2) will always get true.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1208) python TCompactProtocol.py writeBool
and readBool not follow the compact-proto-spec-2.txt spec for
CONTAINER_WRITE, CONTAINER_READ
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1208.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: liwei
I just committed this patch. Thanks liwei!
> python TCompactProtocol.py writeBool and readBool not follow the compact-proto-spec-2.txt spec for CONTAINER_WRITE, CONTAINER_READ
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1208
> URL: https://issues.apache.org/jira/browse/THRIFT-1208
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.6.1
> Reporter: liwei
> Assignee: liwei
> Fix For: 0.7
>
> Attachments: THRIFT-1208.compactproto_readwrite_bool_bug.patch
>
>
> In https://issues.apache.org/jira/secure/attachment/12399869/compact-proto-spec-2.txt, define the boolean value as follow:
> boolean-true => 0x1
> boolean-false => 0x2
> But in TCompactProtocol.py writeBool, readBool for CONTAINER_WRITE, CONTAINER_READ just bool(0x2) will always get true.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira