[GitHub] [cassandra] josh-mckenzie commented on a change in pull request #1246: CASSANDRA-17017 Add required -f option to nodetool verify

[GitBox <gi...@apache.org>]

josh-mckenzie commented on a change in pull request #1246:
URL: https://github.com/apache/cassandra/pull/1246#discussion_r834456683



##########
File path: src/java/org/apache/cassandra/tools/StandaloneVerifier.java
##########
@@ -188,10 +196,16 @@ public static Options parseArgs(String cmdArgs[])
                 }
 
                 String[] args = cmd.getArgs();
-                if (args.length != 2)
+                if (args.length < 2)

Review comment:
       Arguably neutral. It's vestigial from when I had force as a positional argument rather than a - flagged optional and was tinkering a bit, and I ended up leaving it because I liked it a touch more. We could go back to != 2 and ternary if you have strong feelings about it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org