[jira] Commented: (MRELEASE-83) Wrong username during release:prepare tagging

["Torben Giesselmann (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MRELEASE-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=129949#action_129949 ] 

Torben Giesselmann commented on MRELEASE-83:
--------------------------------------------

Same problem with 2.0-beta-8 and SVN.

I looked into {{DefaultScmRepositoryConfigurator}}: the username is contained in the _host_ part of the {{ScmProviderRepositoryWithHost}}, but it's never extracted from that and {{scmRepo.setUser( username )}} is never called with that value.

So I changed that and wrote some code to extract the username and password from the SVN URL. Now the username is set. Therefore, in {{ScmCommitPhase.checkin(...)}} the following code is called

{{result = provider.checkIn( repository, fileSet, (ScmVersion) null, message );}}

with a configured username:
- in the provider's username attribute
- the URL
- and the host name

but _still_ I'm being asked for the wrong username! What is going on after that? I mean: it's a direct call on the {{ScmProvider}}. A problem with the SVN provider implementation?!?

> Wrong username during release:prepare tagging
> ---------------------------------------------
>
>                 Key: MRELEASE-83
>                 URL: http://jira.codehaus.org/browse/MRELEASE-83
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: scm
>            Reporter: Niclas Hedhman
>             Fix For: 2.0-beta-8
>
>
> If I my Svn repository requires a different username than the login name, and I issue 
>    mvn -Dmaven.username=niclas@hedhman.org release:prepare
> The first phase (checking in modified POMs) will succeed with that username.
> Then somewhere between that point and writing out the release.properties file, the user name falls back to the login name (in my case "niclas"), which is written into the release.properties file, and used during the tagging of the repository.
> Now, looking at the source, I think that is unwise to keep a username both in the ReleaseProgressTracker as well as in the ScmHelper, and I suspect that there is some type of sequencing problem in there.
> WORKAROUND;
> Before starting the release:prepare, create a release.properties file manually which contains
>   maven.username=niclas@hedhman.org
> and everything will work.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira