You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Army <qo...@gmail.com> on 2007/06/08 23:57:56 UTC
Re: svn commit: r545639 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
mamta@apache.org wrote:
> DERBY-2777
> I realized that there are no negative test case for parameter inside XMLSERIALIZE funciton.
...
> Parameters are not supported inside XMLSERIALIZE and that's what the new test
> cases are checking.
Just curious: is this different from the check in the "testInvalidXMLBindings()"
method of lang/XMLBindingTest.java? I.e. are we adding this test case here for
collation purposes, or just as a general test case for XMLSERIALIZE?
Army
Re: svn commit: r545639 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
Posted by Mamta Satoor <ms...@gmail.com>.
Yes, at this point, it is not related to collation because parameters are
not supported inside XMLSERIALIZE. But when we do support them, we want to
make sure that the collation type of character string type returned from
XMLSERIALIZE(? AS ...) will have the collation of the current schema and if
it is getting compared against some other character string type of different
collation type, then the test should fail. And that is why I put the test in
the collation test.
If it seems more appropriate
1)for the test to be in XML test class, I can go ahead and move it there or
2)if something like this already exists, then I can remove the test.
Mamta
On 6/8/07, Daniel John Debrunner <dj...@apache.org> wrote:
>
> Mamta Satoor wrote:
> > Army, I added this additional test case for parameter and XMLSERIALIZE
> > just as a place holder so in future, at some point, if we do support
> > parameters for
> > XMLERSERIALIZE, we will have a test case which probably will fail and
> > will be a safety check to make sure parameter and XMLSERIALIZE will work
> > fine.
>
> Why is it in collation tests though? It's not related to collation so it
> should be in an XML test class. But as Army says, it's already tested
> there.
>
> Dan.
>
Re: svn commit: r545639 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
Posted by Daniel John Debrunner <dj...@apache.org>.
Mamta Satoor wrote:
> Army, I added this additional test case for parameter and XMLSERIALIZE
> just as a place holder so in future, at some point, if we do support
> parameters for
> XMLERSERIALIZE, we will have a test case which probably will fail and
> will be a safety check to make sure parameter and XMLSERIALIZE will work
> fine.
Why is it in collation tests though? It's not related to collation so it
should be in an XML test class. But as Army says, it's already tested there.
Dan.
Re: svn commit: r545639 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/CollationTest.java
Posted by Mamta Satoor <ms...@gmail.com>.
Army, I added this additional test case for parameter and XMLSERIALIZE just
as a place holder so in future, at some point, if we do support parameters
for
XMLERSERIALIZE, we will have a test case which probably will fail and will
be a safety check to make sure parameter and XMLSERIALIZE will work fine.
Mamta
On 6/8/07, Army <qo...@gmail.com> wrote:
>
> mamta@apache.org wrote:
>
> > DERBY-2777
> > I realized that there are no negative test case for parameter inside
> XMLSERIALIZE funciton.
> ...
> > Parameters are not supported inside XMLSERIALIZE and that's what the new
> test
> > cases are checking.
>
> Just curious: is this different from the check in the
> "testInvalidXMLBindings()"
> method of lang/XMLBindingTest.java? I.e. are we adding this test case
> here for
> collation purposes, or just as a general test case for XMLSERIALIZE?
>
> Army
>
>