Trace and cancel update patches part 2

[Bill Tutt <ra...@lyra.org>]

Here is the "move the trace commit, and trace update editors from the
command line client and into libsvn_client" patch.

Log:
* clients/cmdline/subversion_client.dsp: Remove trace-commit.c and
    trace-update.c.
* clients/cmdline/trace-commit.c: Deleted, and moved to libsvn_client.
* clients/cmdline/trace-update.c: Deleted, and moved to libsvn_client.
* clients/cmdline/cl.h: (svn_cl__get_trace_update_editor): Remove
prototype.
    (svn_cl__get_trace_commit_editor): Remove prototype.
* libsvn_client/trace-commit.c: Added, and moved from
    clients/cmdline/trace-commit.c. (svn_cl__get_trace_update_editor):
Rename
    to svn_client_get_trace_update_editor. 
* libsvn_client/trace-update.c: Added, and moved from
    clients/cmdline/trace-update.c. (svn_cl__get_trace_commit_editor):
Rename
    to svn_client_get_trace_commit_editor.
* include/svn_client.h: (svn_client_get_trace_commit_editor): Add
prototype.
    (svn_client_get_trace_update_editor): Add prototype.
* libsvn_client/libsvn_client.dsp: Add trace-commit.c. Add
trace-update.c.
* clients/cmdline/checkout-cmd.c: (svn_cl__checkout): Call
    svn_client_get_trace_update_editor.
* clients/cmdline/commit-cmd.c: (svn_cl__commit): Call
    svn_client_get_trace_commit_editor.
* clients/cmdline/copy-cmd.c: (svn_cl__copy): Call
    svn_client_get_trace_update_editor.
* clients/cmdline/import-cmd.c: (svn_cl__import): Call
    svn_client_get_trace_commit_editor.
* clients/cmdline/update-cmd.c: (svn_cl__update): Call
    svn_client_get_trace_editor.

RE: Trace and cancel update patches part 2

[Sander Striker <st...@apache.org>]

> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: 10 January 2002 12:40
> To: Bill Tutt
> Cc: dev@subversion.tigris.org
> Subject: Re: Trace and cancel update patches part 2
> 
> 
> On Sun, Dec 23, 2001 at 10:56:21PM -0800, Bill Tutt wrote:
> > Here is the "move the trace commit, and trace update editors from the
> > command line client and into libsvn_client" patch.
> 
> This patch is dependent upon "part 3" because p3 is needed to remove the
> printf() calls introduced into libsvn_client by this patch.
> 
> However, p3 also issues formatted strings. Similar to Kevin, I have
> reservations about that. In fact, quite serious reservations. I don't think
> that libsvn_client should be in the business of formatting anything for the
> user.
> 
> IMO, the ui_funcs structure that you introduced should have a wide variety
> of callbacks. You could have a function says thats file_op(op, filename)
> where op is one of ADDED or DELETED or whatever. Or, have file_added() etc.
> Essentially, pass the relevant data and let the callback do the formatting.
> 
> I believe you responded to Kevin and said "but all clients shouldn't have to
> duplicate the formatting". That's bogus. What'll eventually happen is that
> some client will have to *parse* that string to figure out what is
> happening. Then we're doomed.

One solution would be:
 - create the callbacks
 - prevent default functions that can be used as a callback
   (which eliminates code dup in the common case).
 
> So... pending further change or discussion, -1 on parts 2 and 3.
> 
> Cheers,
> -g

Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Trace and cancel update patches part 2

[Greg Stein <gs...@lyra.org>]

On Sun, Dec 23, 2001 at 10:56:21PM -0800, Bill Tutt wrote:
> Here is the "move the trace commit, and trace update editors from the
> command line client and into libsvn_client" patch.

This patch is dependent upon "part 3" because p3 is needed to remove the
printf() calls introduced into libsvn_client by this patch.

However, p3 also issues formatted strings. Similar to Kevin, I have
reservations about that. In fact, quite serious reservations. I don't think
that libsvn_client should be in the business of formatting anything for the
user.

IMO, the ui_funcs structure that you introduced should have a wide variety
of callbacks. You could have a function says thats file_op(op, filename)
where op is one of ADDED or DELETED or whatever. Or, have file_added() etc.
Essentially, pass the relevant data and let the callback do the formatting.

I believe you responded to Kevin and said "but all clients shouldn't have to
duplicate the formatting". That's bogus. What'll eventually happen is that
some client will have to *parse* that string to figure out what is
happening. Then we're doomed.

So... pending further change or discussion, -1 on parts 2 and 3.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org