You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/13 01:25:50 UTC

svn commit: r1748075 - in /poi/trunk: ./ src/examples/src/org/apache/poi/ss/examples/ src/java/org/apache/poi/ss/usermodel/ src/java/org/apache/poi/ss/util/ src/testcases/org/apache/poi/ss/util/

Author: onealj
Date: Mon Jun 13 01:25:50 2016
New Revision: 1748075

URL: http://svn.apache.org/viewvc?rev=1748075&view=rev
Log:
bug 58787: reintegrate changes from ss_border_property_template branch at r1748074. The BorderPropertyTemplate allows changes to border formatting to be staged in a template and applied to a sheet at a later time. This reduces the number of intermediate styles created, reduces interactions with cell objects (CellUtil.get/setCellProperties), and makes it easier to make the same formatting changes to multiple sheets. This utility can currently apply border line style and border color. This utility also adds the ability to add a border around a cell range rather than a single cell. Contributed by Mark Murphy.

Added:
    poi/trunk/src/examples/src/org/apache/poi/ss/examples/DrawingBorders.java
      - copied unchanged from r1748074, poi/branches/ss_border_property_template/src/examples/src/org/apache/poi/ss/examples/DrawingBorders.java
    poi/trunk/src/java/org/apache/poi/ss/util/BorderPropertyTemplate.java
      - copied unchanged from r1748074, poi/branches/ss_border_property_template/src/java/org/apache/poi/ss/util/BorderPropertyTemplate.java
    poi/trunk/src/testcases/org/apache/poi/ss/util/TestBorderPropertyTemplate.java
      - copied unchanged from r1748074, poi/branches/ss_border_property_template/src/testcases/org/apache/poi/ss/util/TestBorderPropertyTemplate.java
Modified:
    poi/trunk/   (props changed)
    poi/trunk/src/java/org/apache/poi/ss/usermodel/CellStyle.java
    poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java

Propchange: poi/trunk/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jun 13 01:25:50 2016
@@ -1,6 +1,7 @@
 /poi/branches/common_sl:1661320-1691849
 /poi/branches/excelant:1069732-1073692
 /poi/branches/gsoc2012:1341450-1371650
+/poi/branches/ss_border_property_template:1747847-1748074
 /poi/branches/xml_signature:1617139-1628347
 /poi/branches/xssf_structured_references:1747607-1747656
 /poi/trunk:693591-694881,695264-695420,695621,695649-711764

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/CellStyle.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/CellStyle.java?rev=1748075&r1=1748074&r2=1748075&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/CellStyle.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/CellStyle.java Mon Jun 13 01:25:50 2016
@@ -562,7 +562,7 @@ public interface CellStyle {
 
     /**
      * get the color to use for the top border
-     * @return hhe index of the color definition
+     * @return the index of the color definition
      */
     short getTopBorderColor();
 

Modified: poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java?rev=1748075&r1=1748074&r2=1748075&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/CellUtil.java Mon Jun 13 01:25:50 2016
@@ -42,6 +42,7 @@ import org.apache.poi.ss.usermodel.Workb
  */
 public final class CellUtil {
 
+    // FIXME: Move these constants into an enum
     public static final String ALIGNMENT = "alignment";
     public static final String BORDER_BOTTOM = "borderBottom";
     public static final String BORDER_LEFT = "borderLeft";



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org