You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/08/09 21:36:11 UTC
Review Request: Enabling -Wall -Werror on the build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs
-----
src/Makefile.am 75f8083
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp 957c413
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 42dbf06
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp d21ff3c
src/master/master.cpp 4f62687
src/sched/sched.cpp a147e90
src/slave/slave.hpp 7e860e1
src/slave/slave.cpp c8374b1
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp b3db13d
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp f892282
src/tests/flags_tests.cpp 1372b0a
src/tests/log_tests.cpp 9397da4
src/tests/master_tests.cpp b586984
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp c004772
src/tests/resources_tests.cpp 897422f
src/tests/slave_tests.cpp c190666
src/tests/stout_tests.cpp 0cb39b9
src/tests/utils.hpp a768360
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp 4b1e368
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 9, 2012, 9:28 p.m., Vinod Kone wrote:
> > src/configurator/configurator.cpp, line 167
> > <https://reviews.apache.org/r/6499/diff/1/?file=136480#file136480line167>
> >
> > kill ws
done (not introduced by me :))
> On Aug. 9, 2012, 9:28 p.m., Vinod Kone wrote:
> > src/log/coordinator.hpp, line 102
> > <https://reviews.apache.org/r/6499/diff/1/?file=136491#file136491line102>
> >
> > no need for const
ignored as discussed
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10088
-----------------------------------------------------------
On Aug. 9, 2012, 10:36 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2012, 10:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10088
-----------------------------------------------------------
Ship it!
src/configurator/configurator.cpp
<https://reviews.apache.org/r/6499/#comment21384>
kill ws
src/log/coordinator.hpp
<https://reviews.apache.org/r/6499/#comment21385>
no need for const
- Vinod Kone
On Aug. 9, 2012, 7:36 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2012, 7:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 10, 2012, 3:22 a.m., Benjamin Hindman wrote:
> > src/master/master.cpp, line 674
> > <https://reviews.apache.org/r/6499/diff/2/?file=136757#file136757line674>
> >
> > You can replace this line with:
> >
> > foreachvalue (Slave* slave, slaves) {
> >
> > And then you shouldn't need to use the 'slaveId' below as you did.
done
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10105
-----------------------------------------------------------
On Aug. 10, 2012, 5:42 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 5:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10105
-----------------------------------------------------------
This is fantastic!
src/log/coordinator.hpp
<https://reviews.apache.org/r/6499/#comment21396>
Just curious, what were the warnings for this one?
src/log/coordinator.cpp
<https://reviews.apache.org/r/6499/#comment21397>
Ditto above.
src/master/master.cpp
<https://reviews.apache.org/r/6499/#comment21398>
You can replace this line with:
foreachvalue (Slave* slave, slaves) {
And then you shouldn't need to use the 'slaveId' below as you did.
src/state/serializer.hpp
<https://reviews.apache.org/r/6499/#comment21399>
Again, what was the warning here?
src/tests/flags_tests.cpp
<https://reviews.apache.org/r/6499/#comment21400>
I always thought you can cast 'argv' below to eliminate the warning without needing to do this?
src/zookeeper/group.cpp
<https://reviews.apache.org/r/6499/#comment21401>
This line actually shouldn't be necessary!
- Benjamin Hindman
On Aug. 9, 2012, 10:36 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2012, 10:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 10, 2012, 11:11 p.m., Jie Yu wrote:
> > src/configurator/configurator.cpp, line 170
> > <https://reviews.apache.org/r/6499/diff/4/?file=137987#file137987line170>
> >
> > kill tailing spaces.
done
> On Aug. 10, 2012, 11:11 p.m., Jie Yu wrote:
> > src/configurator/configurator.cpp, line 172
> > <https://reviews.apache.org/r/6499/diff/4/?file=137987#file137987line172>
> >
> > Ditto.
done
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10158
-----------------------------------------------------------
On Aug. 13, 2012, 5:20 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2012, 5:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am b0cb6cc
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 0eca2fa
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 10c537b
> src/slave/slave.cpp 4efd41e
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp 98efb0d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/gc_tests.cpp 2f0bdde
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp 1366032
> src/tests/resources_tests.cpp 897422f
> src/tests/stout_tests.cpp 91bcc13
> src/tests/utils.hpp caf5926
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp b1eceb3
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10158
-----------------------------------------------------------
Ship it!
Ship It!
src/configurator/configurator.cpp
<https://reviews.apache.org/r/6499/#comment21513>
kill tailing spaces.
src/configurator/configurator.cpp
<https://reviews.apache.org/r/6499/#comment21514>
Ditto.
- Jie Yu
On Aug. 10, 2012, 11:02 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 11:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am b0cb6cc
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 10c537b
> src/slave/slave.cpp 4efd41e
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/gc_tests.cpp 2f0bdde
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/stout_tests.cpp 91bcc13
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp b1eceb3
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
(Updated Aug. 24, 2012, 9:22 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Changes
-------
pulled and fixed new warnings
ready for submit
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs (updated)
-----
src/Makefile.am aaceee3
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp e0e17b0
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 742bf0c
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp af03bc3
src/master/master.cpp d3eab98
src/sched/sched.cpp a147e90
src/slave/slave.hpp 10c537b
src/slave/slave.cpp 4efd41e
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp 9725c2e
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp 3cbab2b
src/tests/flags_tests.cpp 1372b0a
src/tests/gc_tests.cpp 68f6e53
src/tests/log_tests.cpp 85b2329
src/tests/master_tests.cpp 36dd6a0
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp 6718fb1
src/tests/resources_tests.cpp 7dcf506
src/tests/sorter_tests.cpp 2b00a7f
src/tests/stout_tests.cpp 91bcc13
src/tests/utils.hpp 83d5daa
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp b1eceb3
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10413
-----------------------------------------------------------
Ship it!
Hottttttttnesssssssssss.
- Benjamin Hindman
On Aug. 13, 2012, 5:20 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2012, 5:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am b0cb6cc
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 0eca2fa
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 10c537b
> src/slave/slave.cpp 4efd41e
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp 98efb0d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/gc_tests.cpp 2f0bdde
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp 1366032
> src/tests/resources_tests.cpp 897422f
> src/tests/stout_tests.cpp 91bcc13
> src/tests/utils.hpp caf5926
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp b1eceb3
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
(Updated Aug. 13, 2012, 5:20 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Changes
-------
Ben, before you patch this in, you will want to pull and make/make check to look for new warnings introduced since now.
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs (updated)
-----
src/Makefile.am b0cb6cc
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp 957c413
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 42dbf06
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp d21ff3c
src/master/master.cpp 0eca2fa
src/sched/sched.cpp a147e90
src/slave/slave.hpp 10c537b
src/slave/slave.cpp 4efd41e
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp 98efb0d
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp f892282
src/tests/flags_tests.cpp 1372b0a
src/tests/gc_tests.cpp 2f0bdde
src/tests/log_tests.cpp 9397da4
src/tests/master_tests.cpp b586984
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp 1366032
src/tests/resources_tests.cpp 897422f
src/tests/stout_tests.cpp 91bcc13
src/tests/utils.hpp caf5926
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp b1eceb3
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
(Updated Aug. 10, 2012, 11:02 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Changes
-------
changed the argv assignment to casts
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs (updated)
-----
src/Makefile.am b0cb6cc
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp 957c413
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 42dbf06
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp d21ff3c
src/master/master.cpp 4f62687
src/sched/sched.cpp a147e90
src/slave/slave.hpp 10c537b
src/slave/slave.cpp 4efd41e
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp b3db13d
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp f892282
src/tests/flags_tests.cpp 1372b0a
src/tests/gc_tests.cpp 2f0bdde
src/tests/log_tests.cpp 9397da4
src/tests/master_tests.cpp b586984
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp c004772
src/tests/resources_tests.cpp 897422f
src/tests/stout_tests.cpp 91bcc13
src/tests/utils.hpp a768360
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp b1eceb3
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10130
-----------------------------------------------------------
src/log/coordinator.hpp
<https://reviews.apache.org/r/6499/#comment21469>
signed / unsigned comparisons elsewhere against it, and I figured quorums sizes are always non-negative, correct?
src/log/coordinator.cpp
<https://reviews.apache.org/r/6499/#comment21470>
again, size/unsigned comps, typically these are against the size_t types, like size() of a vector or string length
src/state/serializer.hpp
<https://reviews.apache.org/r/6499/#comment21471>
unused var (message), changed to static_cast merely to avoid an extra:
(void)message;
statement afterwards
src/tests/flags_tests.cpp
<https://reviews.apache.org/r/6499/#comment21473>
so the warning here was: "warning: deprecated conversion from string constant to 'char*'' on each assignment line (165-170), not sure how casting helps?
src/zookeeper/group.cpp
<https://reviews.apache.org/r/6499/#comment21474>
ok, removed
- Ben Mahler
On Aug. 10, 2012, 5:42 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 5:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
(Updated Aug. 10, 2012, 5:42 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs (updated)
-----
src/Makefile.am 75f8083
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp 957c413
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 42dbf06
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp d21ff3c
src/master/master.cpp 4f62687
src/sched/sched.cpp a147e90
src/slave/slave.hpp 7e860e1
src/slave/slave.cpp c8374b1
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp b3db13d
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp f892282
src/tests/flags_tests.cpp 1372b0a
src/tests/log_tests.cpp 9397da4
src/tests/master_tests.cpp b586984
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp c004772
src/tests/resources_tests.cpp 897422f
src/tests/slave_tests.cpp c190666
src/tests/stout_tests.cpp 0cb39b9
src/tests/utils.hpp a768360
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp 4b1e368
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/
-----------------------------------------------------------
(Updated Aug. 9, 2012, 10:36 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Description
-------
Also, be sure to see my TODO in src/tests/utils.hpp
This addresses bug MESOS-253.
https://issues.apache.org/jira/browse/MESOS-253
Diffs (updated)
-----
src/Makefile.am 75f8083
src/common/attributes.cpp 77be97c
src/common/resources.cpp 7b410ff
src/common/values.cpp 957c413
src/configurator/configurator.cpp 135fbd2
src/configurator/option.hpp 6982ec3
src/examples/balloon_framework.cpp 045ba08
src/examples/long_lived_framework.cpp 369975b
src/examples/no_executor_framework.cpp b5f4ff9
src/examples/test_framework.cpp 7e0c2e2
src/exec/exec.cpp c9f87fa
src/java/jni/convert.cpp 9f52ca8
src/jvm/jvm.cpp 0e3614d
src/launcher/launcher.cpp 35cc6dd
src/local/local.cpp 42dbf06
src/log/coordinator.hpp d585b7d
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/master/constants.hpp 9214bab
src/master/master.hpp d21ff3c
src/master/master.cpp 4f62687
src/sched/sched.cpp a147e90
src/slave/slave.hpp 7e860e1
src/slave/slave.cpp c8374b1
src/state/serializer.hpp 8b28408
src/tests/allocator_tests.cpp b3db13d
src/tests/attributes_tests.cpp 1e87d923
src/tests/exception_tests.cpp d0d17c4
src/tests/fault_tolerance_tests.cpp f892282
src/tests/flags_tests.cpp 1372b0a
src/tests/log_tests.cpp 9397da4
src/tests/master_tests.cpp b586984
src/tests/multihashmap_tests.cpp c399362
src/tests/resource_offers_tests.cpp c004772
src/tests/resources_tests.cpp 897422f
src/tests/slave_tests.cpp c190666
src/tests/stout_tests.cpp 0cb39b9
src/tests/utils.hpp a768360
src/tests/zookeeper_tests.cpp 7336705
src/webui/webui.cpp 1849ef0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/url.hpp d6d4750
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/protobuf.hpp 6dad48b
third_party/libprocess/include/stout/cache.hpp 8a7c332
third_party/libprocess/include/stout/os.hpp 4b1e368
third_party/libprocess/include/stout/strings.hpp 5bf0489
third_party/libprocess/include/stout/time.hpp 46d7077
Diff: https://reviews.apache.org/r/6499/diff/
Testing
-------
make
make check
Thanks,
Ben Mahler
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 9, 2012, 7:52 p.m., Jie Yu wrote:
> > src/state/serializer.hpp, line 38
> > <https://reviews.apache.org/r/6499/diff/1/?file=136500#file136500line38>
> >
> > Can we replace that with a static_cast?
replaced, still need a (void) on there to silence 'statement with no effect' warning.
> On Aug. 9, 2012, 7:52 p.m., Jie Yu wrote:
> > src/tests/utils.hpp, line 160
> > <https://reviews.apache.org/r/6499/diff/1/?file=136513#file136513line160>
> >
> > It's misleading, I would say change that.
done
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10083
-----------------------------------------------------------
On Aug. 9, 2012, 10:36 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2012, 10:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Enabling -Wall -Werror on the build
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6499/#review10083
-----------------------------------------------------------
src/state/serializer.hpp
<https://reviews.apache.org/r/6499/#comment21360>
Can we replace that with a static_cast?
src/tests/utils.hpp
<https://reviews.apache.org/r/6499/#comment21364>
It's misleading, I would say change that.
- Jie Yu
On Aug. 9, 2012, 7:36 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6499/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2012, 7:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> Also, be sure to see my TODO in src/tests/utils.hpp
>
>
> This addresses bug MESOS-253.
> https://issues.apache.org/jira/browse/MESOS-253
>
>
> Diffs
> -----
>
> src/Makefile.am 75f8083
> src/common/attributes.cpp 77be97c
> src/common/resources.cpp 7b410ff
> src/common/values.cpp 957c413
> src/configurator/configurator.cpp 135fbd2
> src/configurator/option.hpp 6982ec3
> src/examples/balloon_framework.cpp 045ba08
> src/examples/long_lived_framework.cpp 369975b
> src/examples/no_executor_framework.cpp b5f4ff9
> src/examples/test_framework.cpp 7e0c2e2
> src/exec/exec.cpp c9f87fa
> src/java/jni/convert.cpp 9f52ca8
> src/jvm/jvm.cpp 0e3614d
> src/launcher/launcher.cpp 35cc6dd
> src/local/local.cpp 42dbf06
> src/log/coordinator.hpp d585b7d
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/master/constants.hpp 9214bab
> src/master/master.hpp d21ff3c
> src/master/master.cpp 4f62687
> src/sched/sched.cpp a147e90
> src/slave/slave.hpp 7e860e1
> src/slave/slave.cpp c8374b1
> src/state/serializer.hpp 8b28408
> src/tests/allocator_tests.cpp b3db13d
> src/tests/attributes_tests.cpp 1e87d923
> src/tests/exception_tests.cpp d0d17c4
> src/tests/fault_tolerance_tests.cpp f892282
> src/tests/flags_tests.cpp 1372b0a
> src/tests/log_tests.cpp 9397da4
> src/tests/master_tests.cpp b586984
> src/tests/multihashmap_tests.cpp c399362
> src/tests/resource_offers_tests.cpp c004772
> src/tests/resources_tests.cpp 897422f
> src/tests/slave_tests.cpp c190666
> src/tests/stout_tests.cpp 0cb39b9
> src/tests/utils.hpp a768360
> src/tests/zookeeper_tests.cpp 7336705
> src/webui/webui.cpp 1849ef0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/url.hpp d6d4750
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/protobuf.hpp 6dad48b
> third_party/libprocess/include/stout/cache.hpp 8a7c332
> third_party/libprocess/include/stout/os.hpp 4b1e368
> third_party/libprocess/include/stout/strings.hpp 5bf0489
> third_party/libprocess/include/stout/time.hpp 46d7077
>
> Diff: https://reviews.apache.org/r/6499/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>