[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #534: HDDS-2987. Add metrics to OM DoubleBuffer.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on issue #534: HDDS-2987. Add metrics to OM DoubleBuffer.
URL: https://github.com/apache/hadoop-ozone/pull/534#issuecomment-584221061
 
 
   > Thanks the patch @bharatviswa504
   > 
   > Overall it looks good. I have a small question inline.
   > 
   > And one note: I am not sure if calculating the average it the most effective way. External metrics tool (like prometheus) can do it in a much smarter way (instead of calculating an generic average, they can return with moving average).
   > 
   > After a few days a global average couldn't say too much about the current state. (But I have no problem to commit it, if you really need it...)
   
   Thank You @elek for the review. So here the suggestion is to use MutableRate, which will calculcate Average automatically? But anyway the current implementation also does the same right, totalNumberOfFlushedTransactions/totalFlushOps which gives the same value over time. let me know your thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org