You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/28 14:36:54 UTC
[GitHub] [airflow] norm opened a new pull request, #25370: Add and document description fields
norm opened a new pull request, #25370:
URL: https://github.com/apache/airflow/pull/25370
Adds the description field to variables API calls, and documents that the connections API was already including it.
Closes #22007.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #25370:
URL: https://github.com/apache/airflow/pull/25370#discussion_r935857557
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2238,6 +2238,9 @@ components:
conn_type:
type: string
description: The connection type.
+ description:
+ type: string
+ description: The description of the connection.
Review Comment:
The *New in version 2.4.0* is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] norm commented on a diff in pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
norm commented on code in PR #25370:
URL: https://github.com/apache/airflow/pull/25370#discussion_r935883953
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2238,6 +2238,9 @@ components:
conn_type:
type: string
description: The connection type.
+ description:
+ type: string
+ description: The description of the connection.
Review Comment:
Ah but it isn't new in 2.4. It was there before, just not documented :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #25370:
URL: https://github.com/apache/airflow/pull/25370#discussion_r932659724
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2238,6 +2238,9 @@ components:
conn_type:
type: string
description: The connection type.
+ description:
+ type: string
+ description: The description of the connection.
Review Comment:
```suggestion
description: |
The description of the connection.
*New in version 2.4.0*
nullable: true
```
We can add nullable for both descriptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25370:
URL: https://github.com/apache/airflow/pull/25370#issuecomment-1202727108
Looks like one of the generated files managed by pre-commit needs updating @norm `airflow/www/static/js/types/api-generated.ts` -- `pre-commit run` should make the changes for you locally then you only need to commit them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #25370:
URL: https://github.com/apache/airflow/pull/25370#discussion_r932659724
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2238,6 +2238,9 @@ components:
conn_type:
type: string
description: The connection type.
+ description:
+ type: string
+ description: The description of the connection.
Review Comment:
```suggestion
description: |
The description of the connection.
*New in version 2.4.0*
nullable: true
```
We can add nullable for both descriptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #25370:
URL: https://github.com/apache/airflow/pull/25370#discussion_r932659724
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -2238,6 +2238,9 @@ components:
conn_type:
type: string
description: The connection type.
+ description:
+ type: string
+ description: The description of the connection.
Review Comment:
```suggestion
description: |
The description of the connection.
*New in version 2.4.0*
nullable: true
```
We can add nullable for both descriptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25370:
URL: https://github.com/apache/airflow/pull/25370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25370: Add and document description fields
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25370:
URL: https://github.com/apache/airflow/pull/25370#issuecomment-1198579306
Tests are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org