[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #5899: AWS: Add additional configurations for Apache Http Client Builder

[GitBox <gi...@apache.org>]

JonasJ-ap commented on code in PR #5899:
URL: https://github.com/apache/iceberg/pull/5899#discussion_r985050217


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -620,12 +712,30 @@ public AwsProperties() {
   public AwsProperties(Map<String, String> properties) {

Review Comment:
   In my first commit, I got CI failure because:
   ```
   [ERROR] /home/runner/work/iceberg/iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:714:3: Method AwsProperties length is 154 lines (max allowed is 150). [MethodLength]
   ```
   Currently, I get around this issue by deleting some blank lines in `AwsProperties(Map<String, String> properties)`. I wonder if there exist a better way to handle this issue, given that we may need to add more properties in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org