You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/21 00:41:41 UTC
[GitHub] [incubator-tvm] shoubhik opened a new pull request #4753: Updating
dependency on Mxnet-mkl
shoubhik opened a new pull request #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753
We need dependency on mxnet mkl package to be able to write tests for end-to-end quantized networks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4753: [Docker]
Updating dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576843391
NOTE: when building the docker image,
I get ERROR: mxnet_mkl-1.5.1-py2.py3-none-manylinux1_x86_64.whl is not a supported wheel on this platform.
This is an interesting error that might has things to do with wheel not recognized in the current docker setup. We will need to fix this and make sure the docker builds properly before proceed
NOTE: the machine has an AMD CPU. It would be great to check whether mkl works on this setting as our CI machines has AMD CPUs. If the quantization tests has to depends on the availability of Intel CPU, perhaps it is a better idea to find a device agnostic way for validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4753:
[Docker] Updating dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#discussion_r369190434
##########
File path: docker/Dockerfile.ci_gpu
##########
@@ -16,7 +16,7 @@
# under the License.
# CI docker GPU env
-# tag: v0.56
+# tag: v0.57
Review comment:
we want to avoid updating the tag before build and test the correctness. I will send a separate PR to do so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on issue #4753: [Docker]
Updating dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik commented on issue #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576832496
I have also updated the tag in Jekins file and the gpu image file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen closed pull request #4753: [Docker] Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik edited a comment on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik edited a comment on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576501654
> the CI is not updated when you update docker. https://docs.tvm.ai/contribute/pull_request.html#ci-environment
>
@masahi , @tqchen , @yzhliu
I read the steps to update docker image here - https://docs.tvm.ai/contribute/pull_request.html#ci-environment.
I have the following question on building a new version of docker image.
When I look at prebuilt images [here](https://hub.docker.com/r/tvmai/ci-gpu/tags) which runs the front end tests, it is built on `linux/amd64`. Any particular reason it is on amd64? the image i build, should it be on amd64 too?
What should be the base instance on which this docker should be built on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576525155
I will merge this PR first, and will report back once we have updated the CI image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4753: [Docker] Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576959165
Update: blocked by https://github.com/apache/incubator-tvm/issues/4764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4753: [Docker] Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576852013
Update: seems was due to latest version of pip, will investigate more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4753: [Docker] Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576843391
NOTE: when building the docker image,
I get ERROR: mxnet_mkl-1.5.1-py2.py3-none-manylinux1_x86_64.whl is not a supported wheel on this platform.
This is an interesting error that might has things to do with wheel not recognized in the current docker setup. We will need to fix this and make sure the docker builds properly before proceed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576478293
the CI is not updated when you update docker. https://docs.tvm.ai/contribute/pull_request.html#ci-environment
so you might as well add pytorch and torhvision update here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik edited a comment on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik edited a comment on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576501654
> the CI is not updated when you update docker. https://docs.tvm.ai/contribute/pull_request.html#ci-environment
>
@masahi , @tqchen , @yzhliu
I read the steps to update docker image here - https://docs.tvm.ai/contribute/pull_request.html#ci-environment.
I have the following question on building a new version of docker image.
When I look at prebuilt images [here](https://hub.docker.com/r/tvmai/ci-gpu/tags) which runs the front end tests, it is built on `linux/amd64`. Any particular reason it is on amd64? the image i build, should it be on amd64 too?
What should be the ec2-instance on which this docker should be built on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik edited a comment on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik edited a comment on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576501654
> the CI is not updated when you update docker. https://docs.tvm.ai/contribute/pull_request.html#ci-environment
>
When I look at prebuilt images [here](https://hub.docker.com/r/tvmai/ci-gpu/tags) which runs the front end tests, it is built on `linux/amd64`. Any particular reason it is on amd64? the image i build, should it be on amd64 too?
What should be the base instance on which this docker should be built on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576525535
The docker can be built on any env. @masahi can you send another PR for pytorch update?
Note that we still need to confirm that all test-cases passes, as there might be problem during CI image update due to breaking dep on upstream. I will be traveling in the incoming week, but will try to keep things updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576577670
Sent a torch update to #4756. I confirmed locally that onnx/test_forward.py, the only place we use torch, works with the updated version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on a change in pull request
#4753: [Docker] Updating dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik commented on a change in pull request #4753: [Docker] Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#discussion_r369191099
##########
File path: docker/Dockerfile.ci_gpu
##########
@@ -16,7 +16,7 @@
# under the License.
# CI docker GPU env
-# tag: v0.56
+# tag: v0.57
Review comment:
got it, i'll revert the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] shoubhik commented on issue #4753: Updating
dependency on Mxnet-mkl
Posted by GitBox <gi...@apache.org>.
shoubhik commented on issue #4753: Updating dependency on Mxnet-mkl
URL: https://github.com/apache/incubator-tvm/pull/4753#issuecomment-576501654
> the CI is not updated when you update docker. https://docs.tvm.ai/contribute/pull_request.html#ci-environment
>
When I look at prebuilt images [here](https://hub.docker.com/r/tvmai/ci-gpu/tags) which runs the front end tests, it is built on `linux/amd64`. Any particular reason it is on amd64? the image i build, should it be on amd64 too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services