You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by PierreCoquentin <gi...@git.apache.org> on 2016/07/30 09:16:49 UTC

[GitHub] kafka pull request #1688: MINOR: Remove unnecessary synchronized block in or...

GitHub user PierreCoquentin opened a pull request:

    https://github.com/apache/kafka/pull/1688

    MINOR: Remove unnecessary synchronized block in org.apache.kafka.streams.processor.internals.StreamTask

    The StreamTask is owned by a specific thread, so it doesn't seem necessary to synchronized the processing of the records as discussed with @guozhangwang  on the dev mailing list

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PierreCoquentin/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1688
    
----
commit 9f2296e79582bcc2811c8ebd5c8c52e95fb46031
Author: PierreCoquentin <pi...@gmail.com>
Date:   2016-07-28T15:36:18Z

    Remove unnecessary synchronized block
    
    The StreamTask is owned by a specific thread, so it doesn't seem necessary to synchronized the processing of the records.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1688: MINOR: Remove unnecessary synchronized block in or...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1688


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---