You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/21 17:50:30 UTC
[GitHub] [age] skkk98 opened a new pull request, #400: Create Cycle Graph Function
skkk98 opened a new pull request, #400:
URL: https://github.com/apache/age/pull/400
Added Cycle Graph Function in the graph_generation.c file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] GhostVaibhav commented on a diff in pull request #400: Create Cycle Graph Function
Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #400:
URL: https://github.com/apache/age/pull/400#discussion_r1056982189
##########
.vscode/c_cpp_properties.json:
##########
@@ -0,0 +1,17 @@
+{
+ "configurations": [
+ {
+ "name": "Linux",
+ "includePath": [
+ "${workspaceFolder}/**",
+ "/home/kalyan/Documents/pgsql-11.17/**"
+ ],
+ "defines": [],
+ "compilerPath": "/usr/bin/gcc",
+ "cStandard": "gnu17",
+ "cppStandard": "gnu++17",
+ "intelliSenseMode": "linux-gcc-x64"
+ }
+ ],
+ "version": 4
+}
Review Comment:
Just remove the files and commit them here, and the PR would be updated automatically. No need for creating a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] GhostVaibhav commented on a diff in pull request #400: Create Cycle Graph Function
Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #400:
URL: https://github.com/apache/age/pull/400#discussion_r1056964267
##########
.vscode/settings.json:
##########
@@ -0,0 +1,6 @@
+{
+ "C_Cpp.errorSquiggles": "Disabled",
+ "files.associations": {
+ "parsenodes.h": "c"
+ }
+}
Review Comment:
Same goes for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] GhostVaibhav commented on a diff in pull request #400: Create Cycle Graph Function
Posted by GitBox <gi...@apache.org>.
GhostVaibhav commented on code in PR #400:
URL: https://github.com/apache/age/pull/400#discussion_r1056964232
##########
.vscode/c_cpp_properties.json:
##########
@@ -0,0 +1,17 @@
+{
+ "configurations": [
+ {
+ "name": "Linux",
+ "includePath": [
+ "${workspaceFolder}/**",
+ "/home/kalyan/Documents/pgsql-11.17/**"
+ ],
+ "defines": [],
+ "compilerPath": "/usr/bin/gcc",
+ "cStandard": "gnu17",
+ "cppStandard": "gnu++17",
+ "intelliSenseMode": "linux-gcc-x64"
+ }
+ ],
+ "version": 4
+}
Review Comment:
Always be sure, **not** to include the files with your environment details (unless required/specified)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] skkk98 commented on a diff in pull request #400: Create Cycle Graph Function
Posted by GitBox <gi...@apache.org>.
skkk98 commented on code in PR #400:
URL: https://github.com/apache/age/pull/400#discussion_r1056972787
##########
.vscode/c_cpp_properties.json:
##########
@@ -0,0 +1,17 @@
+{
+ "configurations": [
+ {
+ "name": "Linux",
+ "includePath": [
+ "${workspaceFolder}/**",
+ "/home/kalyan/Documents/pgsql-11.17/**"
+ ],
+ "defines": [],
+ "compilerPath": "/usr/bin/gcc",
+ "cStandard": "gnu17",
+ "cppStandard": "gnu++17",
+ "intelliSenseMode": "linux-gcc-x64"
+ }
+ ],
+ "version": 4
+}
Review Comment:
Thank you for rectifying it. Should I remove these files and create a new Pull Request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org