You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/03 12:04:33 UTC

[GitHub] [apisix-dashboard] qsliu2017 opened a new pull request #2120: ci: fix buildx

qsliu2017 opened a new pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   This PR aims to fix login bug in docker build ci. I do two changes:
   
   1. login before setup buildx. I guess the old login action may change buildx driver.
   2. use `docker/login-action` instead of `Azure/docker-login`
   
   I don't have an Azure account so I'm not sure it works well. But I've tested Docker Hub and it's ok.
   
   **Related issues**
   
   fix #2108 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2120: ci: fix buildx

Posted by GitBox <gi...@apache.org>.

netlify[bot] commented on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-912486109


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 29248d35fdc342aadd8a6b95ee1ea7bb64633c65
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61320f468544ce0008191c90](https://app.netlify.com/sites/apisix-dashboard/deploys/61320f468544ce0008191c90?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-913966689


   > @qsliu2017 I found a similar issue on this: [Azure/docker-login#12](https://github.com/Azure/docker-login/issues/12). As suggested in [Azure/docker-login#12 (comment)](https://github.com/Azure/docker-login/issues/12#issuecomment-587294567), how about keep using `Azure/docker-login@v1`, but put it right before the `Deploy` step?
   
   Thanks for your help, I've updated it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2120: ci: fix buildx

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-912486109


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 29248d35fdc342aadd8a6b95ee1ea7bb64633c65
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61320f468544ce0008191c90](https://app.netlify.com/sites/apisix-dashboard/deploys/61320f468544ce0008191c90?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2120--apisix-dashboard.netlify.app/](https://deploy-preview-2120--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey merged pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

imjoey merged pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

imjoey commented on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-913280531


   @qsliu2017 I found a similar issue on this: https://github.com/Azure/docker-login/issues/12. As suggested in https://github.com/Azure/docker-login/issues/12#issuecomment-587294567, how about keep using `Azure/docker-login@v1`, but put it right before the `Deploy` step? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-912486109


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 94eeef0186e7867c6482b5ac902c30933a9df0bd
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538](https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2120--apisix-dashboard.netlify.app/](https://deploy-preview-2120--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-913974284


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2120](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94eeef0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/00d80bbfecaef4189c2866fcadbc7db8a978ece3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00d80bb) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2120      +/-   ##
   ==========================================
   + Coverage   67.25%   67.42%   +0.16%     
   ==========================================
     Files         124      126       +2     
     Lines        3277     3294      +17     
     Branches      797      802       +5     
   ==========================================
   + Hits         2204     2221      +17     
     Misses       1073     1073              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `67.42% <ø> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/UI/limit-conn.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb25uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
   | [...c/components/Upstream/components/KeepalivePool.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvS2VlcGFsaXZlUG9vbC50c3g=) | `100.00% <0.00%> (ø)` | |
   | [...rc/components/Upstream/components/RetryTimeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cnlUaW1lb3V0LnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `92.40% <0.00%> (+0.19%)` | :arrow_up: |
   | [web/src/components/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL3NlcnZpY2UudHM=) | `87.93% <0.00%> (+1.39%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00d80bb...94eeef0](https://codecov.io/gh/apache/apisix-dashboard/pull/2120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2120: fix: adjust buildx to fix Docker build failed

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2120:
URL: https://github.com/apache/apisix-dashboard/pull/2120#issuecomment-912486109


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 94eeef0186e7867c6482b5ac902c30933a9df0bd
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538](https://app.netlify.com/sites/apisix-dashboard/deploys/6136dec6d343c80007821538?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org