You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pearu (via GitHub)" <gi...@apache.org> on 2026/10/19 18:42:31 UTC
[PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
pearu opened a new pull request, #54659:
URL: https://github.com/apache/arrow/pull/54659
### Rationale for this change
`strptime` accepts a seconds value of 60 (glibc also 61), and the parser added it to the time of day, which wrapped it into the next minute. Arrow cannot represent leap seconds, and the ISO-8601 parser rejects them.
### What changes are included in this PR?
The parser rejects a seconds value of 60 or more. The check applies only when the time of day is used, so Gandiva's `to_date`, which ignores the time, still accepts such values.
### Are these changes tested?
Yes, in `TimestampParser.StrptimeParser`, and a Gandiva `to_date` test checks that a leap second still gives the date when the time is ignored.
### Are there any user-facing changes?
Leap seconds no longer parse with `strptime` formats, except in Gandiva's `to_date`.
### AI usage disclosure
Developed with AI assistance (Claude Code): the fix, the tests and this description were AI-generated under my direction and reviewed line by line by me. I own and can debug these changes. No copyrighted material is included.
* GitHub Issue: #54647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #54659: GH-54647: [C++] Reject leap seconds in the strptime timestamp parser
URL: https://github.com/apache/arrow/pull/54659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
Posted by "pearu (via GitHub)" <gi...@apache.org>.
pearu commented on PR #54659:
URL: https://github.com/apache/arrow/pull/54659#issuecomment-6349223759
@kou @ianmcook could re-open this PR for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54659:
URL: https://github.com/apache/arrow/pull/54659#issuecomment-6274639970
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
**This pull request has been automatically closed because you currently have 4 open pull requests, which is more than the limit of 3.**
Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale.
Once one of [your other open pull requests](https://github.com/apache/arrow/pulls/pearu) has been merged or closed, you are welcome to reopen this one.
See also:
* [Contribution Guidelines - Limit on concurrent pull requests](https://arrow.apache.org/docs/dev/developers/bug_reports.html#pr-limit)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54659:
URL: https://github.com/apache/arrow/pull/54659#issuecomment-6274635941
:warning: GitHub issue #54647 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-54647: [C++] Reject leap seconds in the strptime timestamp parser [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #54659:
URL: https://github.com/apache/arrow/pull/54659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org