You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/03/28 22:43:14 UTC
Review Request 19805: Allow custom properties to be specified in blueprint
configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19805/
-----------------------------------------------------------
Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
Bugs: AMBARI-5268
https://issues.apache.org/jira/browse/AMBARI-5268
Repository: ambari
Description
-------
Allow a user to specify custom properties of any type in a blueprint. The UI currently allows custom properties to be set and these will eventually be exported to a blueprint.
Currently, if a property in a blueprint isn't specified in the stack configurations, it is ignored.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ed485a3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java ae0b2ec
Diff: https://reviews.apache.org/r/19805/diff/
Testing
-------
- updated existing unit test
- successfully ran all unit tests
----------------------------------------------------------------------
Ran 190 tests in 1.360s
OK
----------------------------------------------------------------------
Total run:504
Total errors:0
Total failures:0
OK
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:24.390s
[INFO] Finished at: Fri Mar 28 17:26:13 EDT 2014
[INFO] Final Memory: 28M/123M
[INFO] ------------------------------------------------------------------------
- functional testing with various properties specified in blueprint configuration
Thanks,
John Speidel
Re: Review Request 19805: Allow custom properties to be specified in
blueprint configuration
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19805/#review39012
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On March 28, 2014, 9:43 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19805/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 9:43 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
>
>
> Bugs: AMBARI-5268
> https://issues.apache.org/jira/browse/AMBARI-5268
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow a user to specify custom properties of any type in a blueprint. The UI currently allows custom properties to be set and these will eventually be exported to a blueprint.
>
> Currently, if a property in a blueprint isn't specified in the stack configurations, it is ignored.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ed485a3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java ae0b2ec
>
> Diff: https://reviews.apache.org/r/19805/diff/
>
>
> Testing
> -------
>
> - updated existing unit test
> - successfully ran all unit tests
> ----------------------------------------------------------------------
> Ran 190 tests in 1.360s
>
> OK
> ----------------------------------------------------------------------
> Total run:504
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:24.390s
> [INFO] Finished at: Fri Mar 28 17:26:13 EDT 2014
> [INFO] Final Memory: 28M/123M
> [INFO] ------------------------------------------------------------------------
>
> - functional testing with various properties specified in blueprint configuration
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 19805: Allow custom properties to be specified in
blueprint configuration
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19805/#review38973
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On March 28, 2014, 5:43 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19805/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 5:43 p.m.)
>
>
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
>
>
> Bugs: AMBARI-5268
> https://issues.apache.org/jira/browse/AMBARI-5268
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Allow a user to specify custom properties of any type in a blueprint. The UI currently allows custom properties to be set and these will eventually be exported to a blueprint.
>
> Currently, if a property in a blueprint isn't specified in the stack configurations, it is ignored.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java ed485a3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java ae0b2ec
>
> Diff: https://reviews.apache.org/r/19805/diff/
>
>
> Testing
> -------
>
> - updated existing unit test
> - successfully ran all unit tests
> ----------------------------------------------------------------------
> Ran 190 tests in 1.360s
>
> OK
> ----------------------------------------------------------------------
> Total run:504
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:24.390s
> [INFO] Finished at: Fri Mar 28 17:26:13 EDT 2014
> [INFO] Final Memory: 28M/123M
> [INFO] ------------------------------------------------------------------------
>
> - functional testing with various properties specified in blueprint configuration
>
>
> Thanks,
>
> John Speidel
>
>