You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/10/21 22:42:39 UTC
DO NOT REPLY [Bug 118538] New: hard-coded background color in
Options dialog is problematic on light-on-dark desktop themes
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Bug #: 118538
Issue Type: DEFECT
Summary: hard-coded background color in Options dialog is
problematic on light-on-dark desktop themes
Classification: Code
Product: framework
Version: current
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: code
AssignedTo: tm@openoffice.org
ReportedBy: arielch@openoffice.org
CC: ooo-issues@incubator.apache.org
Reported by Eustace on users@openoffice.org
http://openoffice.org/projects/www/lists/users/archive/2011-09/message/154
"Since I use white on blue color scheme in my system, the title lines in the
same dialog (eg. General, Text Document, HTML Document) have a gray background
(132, 132, 132) which makes the white text difficult to read."
Looking at the code in cui/source/options/optcolor.cxx
the background color of the categories is hard-coded to COL_LIGHTGRAY, that is
RGB( 0xC0, 0xC0, 0xC0) in hex, or (192, 192, 192) in decimal, see
tools/inc/tools/color.hxx
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118538] hard-coded background color in Options dialog is
problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #13 from Rob Weir <ro...@apache.org> ---
I'm adding this comment to all open issues with Issue Type == PATCH. We have
220 such issues, many of them quite old. I apologize for that.
We need your help in prioritizing which patches should be integrated into our
next release, Apache OpenOffice 4.0.
If you have submitted a patch and think it is applicable for AOO 4.0, please
respond with a comment to let us know.
On the other hand, if the patch is no longer relevant, please let us know that
as well.
If you have any general questions or want to discuss this further, please send
a note to our dev mailing list: dev@openoffice.apache.org
Thanks!
-Rob
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Ariel Constenla-Haile <ar...@openoffice.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |STARTED
Issue Type|DEFECT |PATCH
AssignedTo|tm@openoffice.org |arielch@openoffice.org
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118538] hard-coded background color in Options dialog is
problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--- Comment #12 from Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> ---
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #7 from mla@openoffice.org 2011-10-21 23:32:02 UTC ---
> can you explain what you mean by "selected text" and by "selection bar". I
> don't get if we are talking about the same thing here.
>
> Just to use the same terms, this issue is about the background colour in the
> categories on the Tools - Options - OpenOffice.org - Appearance option page,
> that are labelled "General", "Text Document", "HTML Document", "Spreadsheet",
> etc.
> So here there is no selection at all (that's what I don't get in your
> explanation).
OK, forget selection bar. I got it wrong.
In the Draw doc with the pictures on the "current" side it's indeed not
readable. However, in the pictures with "patched" it could be a bit more
lighter. To indentify it better as separation between the "General", "Text
Document", "HTML Document", "Spreadsheet", etc. sections. Especially on slide 4
in the "patched" picture it's really too dark.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Ariel Constenla-Haile <ar...@openoffice.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76917|0 |1
is obsolete| |
--- Comment #11 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-25 23:43:50 UTC ---
Created attachment 76932
--> https://issues.apache.org/ooo/attachment.cgi?id=76932
Screenshots
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #4 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-21 21:02:28 UTC ---
Created attachment 76914
--> https://issues.apache.org/ooo/attachment.cgi?id=76914
Draw doc. with screen-shots before and after applying the patch
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #5 from mla@openoffice.org 2011-10-21 22:28:22 UTC ---
Thanks for reporting this issue and the patch. However, I think the color now
with your patch is a bit too dark and should be lighter. The selected text is
now indeed readable but the selection bar is not really identifiable.
Maybe the problem is not the light color for the selection bar, it could be
also the text color which is too light?
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #1 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-21 20:43:58 UTC ---
Created attachment 76911
--> https://issues.apache.org/ooo/attachment.cgi?id=76911
KDE "Evening Lilac" light-on-dark theme
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #10 from mla@openoffice.org 2011-10-22 09:45:14 UTC ---
Thanks for the new patch and screenshot. I can see the change in the patch
(from 32 to 16), however, it's not visible in the pictures on slide 5. Can you
see a difference?
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #2 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-21 20:44:59 UTC ---
Created attachment 76912
--> https://issues.apache.org/ooo/attachment.cgi?id=76912
KDE "Wonton Soup" light-on-dark theme
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Ariel Constenla-Haile <ar...@openoffice.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76913|0 |1
is obsolete| |
--- Comment #8 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-22 00:43:23 UTC ---
Created attachment 76916
--> https://issues.apache.org/ooo/attachment.cgi?id=76916
Patch - second try (label text color retrieved from style settings)
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
Ariel Constenla-Haile <ar...@openoffice.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76914|0 |1
is obsolete| |
--- Comment #9 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-22 00:44:28 UTC ---
Created attachment 76917
--> https://issues.apache.org/ooo/attachment.cgi?id=76917
Screenshots for 2nd version
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #6 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-21 22:50:44 UTC ---
(In reply to comment #5)
> Thanks for reporting this issue and the patch. However, I think the colour now
> with your patch is a bit too dark and should be lighter. The selected text is
> now indeed readable but the selection bar is not really identifiable.
>
> Maybe the problem is not the light colour for the selection bar, it could be
> also the text colour which is too light?
can you explain what you mean by "selected text" and by "selection bar". I
don't get if we are talking about the same thing here.
Just to use the same terms, this issue is about the background colour in the
categories on the Tools - Options - OpenOffice.org - Appearance option page,
that are labelled "General", "Text Document", "HTML Document", "Spreadsheet",
etc.
So here there is no selection at all (that's what I don't get in your
explanation).
Back to the issue, the text colour (for "General", "Text Document", "HTML
Document", "Spreadsheet", etc.) is the default bold text colour.
That's why I've chosen the dialogue colour for the background: this two colours
are likely to never be the same (otherwise the text written in a dialogue could
not be read).
Then I simply lighten or darken the background colour, so that it differs a
little from the dialogue colour.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118538] hard-coded background color in Options
dialog is problematic on light-on-dark desktop themes
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118538
--- Comment #3 from Ariel Constenla-Haile <ar...@openoffice.org> 2011-10-21 20:58:56 UTC ---
Created attachment 76913
--> https://issues.apache.org/ooo/attachment.cgi?id=76913
Attempt to replace the hard-coded background color
A possible solution could be:
Instead of checking for high-contrast mode, and hard-coding the background
color, we can use the two contrasting colors: the dialog color and the text
color, and lighten or darken the background according to their luminescence
relationship.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.