You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2016/01/19 18:01:43 UTC

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1520

    [FLINK-1666] [FLINK-1903] [FLINK-3233] Refactor expression keys.

    - Unify usage of expression keys: FLINK-1666
    - Unify supported key expressions (incl. support for partitioning on atomic types: FLINK-3233)
    - Remove removal of duplicate keys: FLINK-1903
    - Unify checks for sort keys
    - Add more tests for SelectorFunctionKeys and ExpressionKeys
    - Fixed most compiler warnings in touched files
    
    Sorry for merging several issues in this PR. 
    FLINK-1903 and FLINK-3233 are fixed as a side effect of FLINK-1666.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink expressionKeys

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1520
    
----
commit da515e70746c147d1b95b62318767616e7075051
Author: Fabian Hueske <fh...@apache.org>
Date:   2016-01-14T21:48:43Z

    [FLINK-1666] [FLINK-1903] [FLINK-3233] Refactor expression keys.
    
    - Unify usage of expression keys: FLINK-1666
    - Unify supported key expressions (incl. support for partitioning on atomic types: FLINK-3233)
    - Remove removal of duplicate keys: FLINK-1903
    - Unify checks for sort keys
    - Add more tests for SelectorFunctionKeys and ExpressionKeys

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1520


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1520#issuecomment-174916560
  
    I will merge this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-1666] [FLINK-1903] [FLINK-3233] Refacto...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1520#issuecomment-174478748
  
    Any feedback for this PR? Otherwise, I'll merge it tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---