You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2011/07/23 18:57:28 UTC

svn commit: r1150147 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java

Author: hlship
Date: Sat Jul 23 16:57:27 2011
New Revision: 1150147

URL: http://svn.apache.org/viewvc?rev=1150147&view=rev
Log:
TAP5-1508: Correct @RequestParameter logic to not use PlasticMethod instance after the end of transformation

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java?rev=1150147&r1=1150146&r2=1150147&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/transform/OnEventWorker.java Sat Jul 23 16:57:27 2011
@@ -319,9 +319,11 @@ public class OnEventWorker implements Co
     }
 
 
-    private EventHandlerMethodParameterProvider createQueryParameterProvider(final PlasticMethod method, final int parameterIndex, final String parameterName,
+    private EventHandlerMethodParameterProvider createQueryParameterProvider(PlasticMethod method, final int parameterIndex, final String parameterName,
                                                                              final String parameterTypeName, final boolean allowBlank)
     {
+        final String methodIdentifier = method.getMethodIdentifier();
+
         return new EventHandlerMethodParameterProvider()
         {
             @SuppressWarnings("unchecked")
@@ -354,7 +356,7 @@ public class OnEventWorker implements Co
                     throw new RuntimeException(
                             String.format(
                                     "Unable process query parameter '%s' as parameter #%d of event handler method %s: %s",
-                                    parameterName, parameterIndex + 1, method.getMethodIdentifier(),
+                                    parameterName, parameterIndex + 1, methodIdentifier,
                                     InternalUtils.toMessage(ex)), ex);
                 }
             }