You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/08/12 16:35:53 UTC

DO NOT REPLY [Bug 45613] use of generics in package org.apache.tomcat.util.http

https://issues.apache.org/bugzilla/show_bug.cgi?id=45613





--- Comment #1 from Mark Thomas <ma...@apache.org>  2008-08-12 07:35:52 PST ---
There is some useful work here but also a few things that need to be fixed
before it can be applied to trunk:

- changes such as the one in MimeMap (Hashtable->Map) may break other users of
this class
- Character.isSpace() is not the same as Character.isWhitespace()  (I got
caught out by this a while back)
- Don't comment out code to remove it - delete it. svn can tell us what has
changed and it makes the new code easier to read
- Where the debug field for logging has been removed, the replacement log
messages should all be log.debug(...)
- Spaces are replaced with a tab in at least one place. Tomcat always uses
spaces

Thanks for your efforts so far.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org