You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2012/06/27 16:37:23 UTC

svn commit: r1354539 - /myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java

Author: lofwyr
Date: Wed Jun 27 14:37:22 2012
New Revision: 1354539

URL: http://svn.apache.org/viewvc?rev=1354539&view=rev
Log:
TOBAGO-1166: <tx:menuCheckbox> may produce a duplicated id in JSPs

Modified:
    myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java

Modified: myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java?rev=1354539&r1=1354538&r2=1354539&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java (original)
+++ myfaces/tobago/trunk/tobago-extension/tobago-taglib-extension/src/main/java-jsf-1.2/org/apache/myfaces/tobago/internal/taglib/extension/MenuCheckboxExtensionTag.java Wed Jun 27 14:37:22 2012
@@ -65,9 +65,6 @@ public class MenuCheckboxExtensionTag ex
   private javax.el.ValueExpression transition;
   private javax.el.ValueExpression renderedPartially;
 
-  private String jspId;
-  private int suffixId;
-  
   @Override
   public int doStartTag() throws JspException {
 
@@ -107,7 +104,7 @@ public class MenuCheckboxExtensionTag ex
     if (renderedPartially != null) {
       menuCommandTag.setRenderedPartially(renderedPartially);
     }
-    menuCommandTag.setJspId(jspId + PREFIX + suffixId++);
+    menuCommandTag.setJspId(jspId + PREFIX + idSuffix++);
     menuCommandTag.doStartTag();
 
     facetTag = new FacetTag();
@@ -122,7 +119,7 @@ public class MenuCheckboxExtensionTag ex
       selectBooleanCheckbox.setValue(value);
     }
     selectBooleanCheckbox.setParent(facetTag);
-    selectBooleanCheckbox.setJspId(jspId + PREFIX + suffixId++);
+    selectBooleanCheckbox.setJspId(jspId + PREFIX + idSuffix++);
     selectBooleanCheckbox.doStartTag();
     return super.doStartTag();
   }