You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Subham-KRLX (via GitHub)" <gi...@apache.org> on 2025/07/21 13:21:59 UTC
[PR] Feature/execution api ssl verify 2 [airflow]
Subham-KRLX opened a new pull request, #53589:
URL: https://github.com/apache/airflow/pull/53589
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Add unit test for SSL certificate handling in Client
This PR adds a unit test to verify the new logic for loading a custom SSL certificate from configuration in the Airflow API client.
The test ensures that the client correctly reads the AIRFLOW__API__SSL_CERT environment variable and successfully initializes with the provided certificate path.
This supports the fix for self-signed certificate usage, as discussed in:
related: #53493
related: #53574
The test was verified to pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121789206
This is what I do for years with my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3123947303
Thanks so much for all your helpful reviews and guidance on this PR. I have addressed all the requested changes and updated the branch accordingly. I really appreciate the support from the maintainers and community throughout this process. Please let me know if anything else is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3123803056
Also remember to pull upstream main branch to your local, it seems your local main branch is not up to date with upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3124303251
> Thanks so much for all your helpful reviews and guidance on this PR. I have addressed all the requested changes and updated the branch accordingly. I really appreciate the support from the maintainers and community throughout this process. Please let me know if anything else is needed.
But not in this PR? This one can be closed I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121575021
I have resolved conflicts and fixed SSL verification logic in PR #53589 but my new commits are on detached HEAD and not part of my feature branch. The branch has diverged from remote so push attempts fail as stale. Even after cloning outside AIRFLOW_HOME and trying rebase steps I can’t attach my commits cleanly or push without risking data loss or duplication. Pre-commit and CI fail mainly because repo is checked out inside AIRFLOW_HOME. How do I connect my commits to the branch fix push errors and set up repo to pass CI? I am not worried about Docker errors. I am ready to follow steps and share more info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3123797717
> Also - good advice - only ever "REBASE" your changes on top of other's changes - Ideally git-squash them so that you every have to only rebase a single commit - which makes it easier:
>
> `git rebase HEAD^ --onto=<branch-you-want-to-rebase-on>`
>
> If you have multiple commits you want to keep separate:
>
> `git rebase <FIRST_COMMIT_THAT_IS_NOT_YOURS> --onto=<branch-you-want-to-rebase-on>`
I also set up a command alias for rebasing upstream, which has made my workflow much smoother. No matter which shell you use, it should be straightforward to create a command alias for Git.
Hope the following setup is helpful to you.
in `.zshrc` ( rc file for your shell )
```bash
# git alias
gmb() {
local base
if [[ $(git symbolic-ref --short HEAD) != "$1" ]]; then
echo "Current branch is not $1, checking out $1"
git checkout "$1"
fi
echo "Rebasing $1 onto $2"
base=$(git merge-base "$1" "$2")
git rebase "$base" --onto "$2"
}
```
usage:
```bash
# gmb <your-branch-name> <branch-to-rebase-on>
# in this case
gmb feature/execution-api-ssl-verify-2 main
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121784820
> > I have resolved conflicts and fixed SSL verification logic in PR #53589 but my new commits are on detached HEAD and not part of my feature branch. The branch has diverged from remote so push attempts fail as stale. Even after cloning outside AIRFLOW_HOME and trying rebase steps I can’t attach my commits cleanly or push without risking data loss or duplication. Pre-commit and CI fail mainly because repo is checked out inside AIRFLOW_HOME. How do I connect my commits to the branch fix push errors and set up repo to pass CI? I am not worried about Docker errors. I am ready to follow steps and share more info.
>
> From my experience, if commits history gets messy - try to create a patch from the existing branch (it will only mark the changes), then create another branch from `main`, apply the patch there, commit and create a new PR. I found this guide on [Google](https://www.specbee.com/blogs/how-create-and-apply-patch-git-diff-and-git-apply-commands-our-drupal-website), I hope that it could be helpful.
Yes. Start from scratch and cherry-pick your changes to the current main (or even copy&paste them manuall). Close that PR and open a new from that new branch or delete the old branch locally and name the new brancth to be the same as the original one here and `git push --force` it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121785174
There are likely about 100 ways to do it with git BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121704079
> I have resolved conflicts and fixed SSL verification logic in PR #53589 but my new commits are on detached HEAD and not part of my feature branch. The branch has diverged from remote so push attempts fail as stale. Even after cloning outside AIRFLOW_HOME and trying rebase steps I can’t attach my commits cleanly or push without risking data loss or duplication. Pre-commit and CI fail mainly because repo is checked out inside AIRFLOW_HOME. How do I connect my commits to the branch fix push errors and set up repo to pass CI? I am not worried about Docker errors. I am ready to follow steps and share more info.
From my experience, if commits history gets messy - try to create a patch from the existing branch (it will only mark the changes), then create another branch from `main`, apply the patch there, commit and create a new PR. I found this guide on [Google](https://www.specbee.com/blogs/how-create-and-apply-patch-git-diff-and-git-apply-commands-our-drupal-website), I hope that it could be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3108832981
I have removed the misgenerated files (constraints.txt and s3_task_handler.py) as requested and pushed the updated branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX closed pull request #53589: Feature/execution api ssl verify 2
URL: https://github.com/apache/airflow/pull/53589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3121788761
Also - good advice - only ever "REBASE" your changes on top of other's changes - Ideally git-squash them so that you every have to only rebase a single commit - which makes it easier:
`git rebase HEAD^ --onto=<branch-you-want-to-rebase-on>`
If you have multiple commits you want to keep separate:
`git rebase <FIRST_COMMIT_THAT_IS_NOT_YOURS> --onto=<branch-you-want-to-rebase-on>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/execution api ssl verify 2 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #53589:
URL: https://github.com/apache/airflow/pull/53589#issuecomment-3098256594
After it succeeds, you can change the base and make the PR to @danieldean 's branch - then @danieldean can merge it to his PR and we can merge it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org