You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/03/14 15:38:55 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
JiriOndrusek opened a new pull request, #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653
partially fixes https://github.com/apache/camel-quarkus/issues/4652
Adds CSB test ([PayLoadConvertToPOJOTest](https://github.com/apache/camel-spring-boot/blob/camel-spring-boot-3.x/components-starter/camel-cxf-soap-starter/src/test/java/org/apache/camel/component/cxf/soap/springboot/converter/PayLoadConvertToPOJOTest.java)) for camel-quarkus.
Port of another CSB test ([CxfConsumerPayLoadConverterTest](https://github.com/apache/camel-spring-boot/blob/camel-spring-boot-3.x/components-starter/camel-cxf-soap-starter/src/test/java/org/apache/camel/component/cxf/soap/springboot/CxfConsumerPayLoadConverterTest.java)) is still missing.
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1562735954
@ppalaga This PR can be merged, to allow backporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1211456108
##########
integration-test-groups/cxf-soap/cxf-soap-converter/src/main/resources/application.properties:
##########
@@ -0,0 +1,29 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+quarkus.cxf.path=/soapservice
+quarkus.native.resources.includes = wsdl/*.wsdl
+
+# Workaround for https://github.com/apache/camel-quarkus/issues/4603
+# Should not be needed with the Quarkus release coming after 3.0.0.Alpha5
+quarkus.jaxb.validate-jaxb-context = false
+
+# disable the root config
+quarkus.cxf.codegen.wsdl2java.includes = none.wsdl
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138627950
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
Review Comment:
Hi @ppalaga , I had to add reference to `camel-quarkus-jaxb` to allow converter tests to be successful. On the other hand it might "cover" some issues in cxf (because there is more dependencies). What do you think, should I keep the added dependency (as is now)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1140603747
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-jaxb</artifactId>
+ </dependency>
Review Comment:
Hi @JiriOndrusek @ppalaga ,
The test counterpart in CSB depends on camel-jaxb, needs to use the camel-jaxb converter there.
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1570288476
Perfect, thank @JiriOndrusek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1468366974
Maybe to be merged after the current pending release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1494163768
It is OK to leave the cq-jaxb dependecy in the test. @JiriOndrusek could you please rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138627950
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
Review Comment:
Hi @ppalaga , I had to add reference to camel-quarkus-jaxb to allow converter tests to be successful. On the other hand it might "cover" some issues in cxf (because there is more dependencies). What do you think, should I keep the added dependency (as is now)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138638484
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-jaxb</artifactId>
+ </dependency>
Review Comment:
Hi @ppalaga , I had to add reference to camel-quarkus-jaxb to allow converter tests to be successful. On the other hand it might "cover" some issues in cxf (because there is more dependencies). What do you think, should I keep the added dependency (as is now)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1569918269
All fixed, can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1211248139
##########
integration-test-groups/cxf-soap/cxf-soap-converter/src/main/resources/application.properties:
##########
@@ -0,0 +1,29 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+quarkus.cxf.path=/soapservice
+quarkus.native.resources.includes = wsdl/*.wsdl
+
+# Workaround for https://github.com/apache/camel-quarkus/issues/4603
+# Should not be needed with the Quarkus release coming after 3.0.0.Alpha5
+quarkus.jaxb.validate-jaxb-context = false
+
+# disable the root config
+quarkus.cxf.codegen.wsdl2java.includes = none.wsdl
Review Comment:
```suggestion
```
These should not be needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1494184169
@ppalaga I just recalled, that this change can not be merged. There is a problem (whih happens on CQ not CSB with converters). @ffang is working on it. See https://issues.apache.org/jira/browse/CAMEL-19160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1559732259
CI failure is caused by cxf test from another module:
```
Results:
2023-05-23T12:47:53.3271009Z [INFO]
2023-05-23T12:47:53.3271183Z [ERROR] Errors:
2023-05-23T12:47:53.3271622Z [ERROR] CxfSoapMtomIT>CxfSoapMtomTest.uploadDownloadMtom:57 ยป SocketTimeout Read timed...
2023-05-23T12:47:53.3271930Z [INFO]
2023-05-23T12:47:53.3272162Z [ERROR] Tests run: 55, Failures: 0, Errors: 1, Skipped: 0
```
The failure should not be related to this change (I tested locally the whole `cxf-soap-grouped` module - successfully). Socket timeout may indicate some random issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#issuecomment-1468370931
> Maybe to be merged after the current pending release.
No problem, I'll switch PR to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138627950
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
Review Comment:
Hi @ppalaga , I had to add reference to `camel-quarkus-jaxb` to allow converter tests to be successful. On the other hand it might "cover" some issues in cxf (because there is more dependencies). What do you think, should I keep the added dependency (as is now)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138699136
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-jaxb</artifactId>
+ </dependency>
Review Comment:
That's a good question. I'd say it depends on which kind of errors you saw. If camel-quarkus-jaxb just adds some conveniece converters so that expressions like `exchange.getIn().getBody(GetPerson.class)` work flawlessly, then I'd say it is not a pure camel-cxf use case and it should stay up to the user to add camel-quarkus-jaxb manually.
If the error bubbles up from some pure camel-cxf code, then we need to take a precise look whether it is a bug in camel-quarkus-cxf or even in quarkus-cxf.
BTW, does the CSB test you are porting depend on camel-jaxb?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1155842994
##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-jaxb</artifactId>
+ </dependency>
Review Comment:
OK, it sounds like the separate jaxb dependency is expected then. Let's keep it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org