You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2026/01/30 00:54:42 UTC

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23920


Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................

IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

If the Calcite junit tests fail, the jar file currently does not
get built. Without the existence of the jar, some e2e tests to fail,
making it harder to figure out the root cause. Therefore we should
always ensure the Calcite jar file gets built.

Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/23920/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................


Patch Set 1: Code-Review+2

Looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 19:26:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 16:18:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21533/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 01:56:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 09:37:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13021/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 04:40:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23920 )

Change subject: IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.
......................................................................

IMPALA-14711: Ensure Calcite planner jar file gets built, even if tests fail.

If the Calcite junit tests fail, the jar file currently does not
get built. Without the existence of the jar, some e2e tests to fail,
making it harder to figure out the root cause. Therefore we should
always ensure the Calcite jar file gets built.

Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Reviewed-on: http://gerrit.cloudera.org:8080/23920
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Smith: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23920
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If3fe2b3d652dea55f3b14467e605def62da79da3
Gerrit-Change-Number: 23920
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>