[jira] Commented: (THRIFT-276) Ruby libraries should have one class per file

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664763#action_12664763 ] 

Kevin Clark commented on THRIFT-276:
------------------------------------

I agree entirely. It's only this way for legacy reasons.

> Ruby libraries should have one class per file
> ---------------------------------------------
>
>                 Key: THRIFT-276
>                 URL: https://issues.apache.org/jira/browse/THRIFT-276
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Priority: Trivial
>
> There's no reason for so many of our classes to be lumped into the same file. For instance, transport.rb contains 9 classes. They may be short, but organizationally, it's superior to have separate class files. Of course, some files may contain more than one class per file as appropriate - things like a protocol and its factory, for instance, are perfectly acceptable to group.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.